Ticket #9093 (verify: fixed)
remove dependency on reduction folder from Inelastic
Reported by: | Gesner Passos | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | major | Milestone: | Release 3.5 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | Blocked By: | #10854, #10855 | |
Blocking: | #8812 | Tester: |
Description
Inelastic uses the reduction.Reducer and reduction.ReductionSteps. Both will not be available any more as #8812 will get rid of that folder.
This means that we have to find an agreement about where to put the module that contains the Reducer and ReductionSteps. #9014 put it under SANS folder, but might not like Inelastic. At least, SANS should move the ReductionSteps to another file to allow Inelastic to use it without having to load the entire isis_reduction_steps.py.
Change History
comment:5 Changed 6 years ago by Dan Nixon
- Status changed from assigned to inprogress
Initial merge of reducer funntionality into msg_reducer
Refs #9093
Changeset: 60e14468dde8e8f0bb682b9364bebc268d5e705f
comment:7 Changed 6 years ago by Dan Nixon
More refactoring and PyLint corections
Refs #9093
Changeset: 7fdd0c3791dfc7e32b1b671a5acbe96083dbfa66
comment:9 Changed 6 years ago by Dan Nixon
Removed seperate log file, made doctring style consistant
MSG reductions rarely seemed to output to the log, use of it has been replaced with the kernel logger at information level.
Refs #9093
Changeset: 2a92909f8f6b98bffb5f56d66280a62c5eaa8e59
comment:10 Changed 6 years ago by Dan Nixon
comment:11 Changed 6 years ago by Dan Nixon
Looking at this again, I am tempted to just migrate the reduction routines to the two Python algorithms (InelasticIndirectReduction and MSGDiffractionReduction), keeping the current reducers that inherit reducer for the time being in case any users have scripts that depend on them but make them aware they are likely to be removed.
comment:12 Changed 6 years ago by Dan Nixon
- Milestone changed from Release 3.3 to Backlog
Unlikely to finish this in time for 3.3
comment:18 Changed 5 years ago by Dan Nixon
- Status changed from assigned to verify
- Resolution set to fixed
comment:19 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9936