Ticket #9014 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Remove dependency on reduction code

Reported by: Gesner Passos Owned by: Gesner Passos
Priority: major Milestone: Release 3.2
Component: SANS Keywords:
Cc: Blocked By:
Blocking: #8812, #9015 Tester: Peter Parker

Description

Remove the dependency, by moving the code that is inside reduction folder to SANS folder. This one will create files even bigger inside SANS right now. It is not ideal, but, changing here means that we could eventually break users scripts.

Change History

comment:1 Changed 7 years ago by Gesner Passos

  • Blocking 9015 added

comment:2 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

comment:3 Changed 7 years ago by Gesner Passos

  • Status changed from assigned to inprogress

re #9014: Bring Reducer and ReductionSingleton to SANS folder

Changeset: 4c40ddbf98325c3d461bbe764e2d870ce708975a

comment:4 Changed 7 years ago by Gesner Passos

re #9014: Bring reduction steps to sans_reduction_steps

While moving, I've tried to remove those methods and attributes that we were not using at all. It might have more, which must be investigated in another opportunity.

Changeset: a61bbcd1318553599741f0f771b6600d03fbc587

comment:5 Changed 7 years ago by Gesner Passos

re #9014. Bring Instrument to isis_instrument

Changeset: ef046140177320ce304502c96c51b8952e3e87ec

comment:6 Changed 7 years ago by Gesner Passos

re #9014: Addapt isis_reducer to the changes

Do not use more things on reduction folder, but instead the SANS ones.

Changeset: c05d1abf4bda83d4be5295904e46668989a71253

comment:7 Changed 7 years ago by Gesner Passos

re #9014 Update centre_finder to not user old sans_reduction_steps

Changeset: bcfde5653e835fd97b54efbffcb5204ea19e09d5

comment:8 Changed 7 years ago by Gesner Passos

re #9014. Adapt ISISCommandInterface to use only SANS folder

Changeset: 0806e1df85246cba8817924b24f5e1c9998088eb

comment:9 Changed 7 years ago by Gesner Passos

re #9014 Improve usage of mantidplot when not in GUI mode

While testing the changes, I've seen that we were silently ignoring exception when trying to use mantidplot in script mode. It is better to check if it is available and use only when it is.

Changeset: 1d0f78a77298a9cd6cfd25ba564006e3090fa818

comment:10 Changed 7 years ago by Gesner Passos

re #9014. Improve the solution for long log

The changes here were introduced in #8949, but while testing the changes through the systemtests I reckognise that some times it may return a single value. Hence, here it tests first if there are more than one value before selecting the last one.

Changeset: f2290b50c26e7167b1055907fec2c79df0287f07

comment:11 Changed 7 years ago by Gesner Passos

re #9014. Ensure assumption of receiving workspace reference

While checking this ticket I found that some system tests were passing string to this method and were 'silently' being ignored. This, fixes it.

Changeset: 77625780a4abd71cfcc6285d8fbc9e743c7f8a2b

comment:12 Changed 7 years ago by Gesner Passos

re #9014: Move the reducer_singleton to scripts folder

This is to allow Indirect to use the same module. And because it is not strictly related to SANS.

Changeset: a4dc6128ac5fcf8f9656327273af0b27c6872e6f

comment:13 Changed 7 years ago by Gesner Passos

re #9014: Move ReductionStep to reducer_singleton module

After discussion, this allows Indirect to use all they need to implement #9093.

Changeset: 03f4790a470900e9695383d547a3663725d8f999

comment:14 Changed 7 years ago by Gesner Passos

Tester:

This ticket was mainly getting from reduction folder what we are already using for the SANS reduction. Everything should be working as before. The systemtests are telling that we have all running, and our GUI do not write any code using that folder directly (Well, we have to wait till Friday to be sure, last commit was on Thursday).

Hence, code review is the main point here.

comment:15 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:16 Changed 7 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:17 Changed 7 years ago by Peter Parker

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9014_isis_sans_dependency'

Full changeset: b917118a88af204aa85096c34b653415aecf1fc7

comment:18 Changed 7 years ago by Peter Parker

Inspected each commit for the code review, and each change made sense in the context of the ticket.

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9857

Note: See TracTickets for help on using tickets.