Ticket #9013 (closed)

Opened 7 years ago

Last modified 5 years ago

Load ILL Indirect Geometry IN16B

Reported by: Ricardo Leal Owned by: Ricardo Leal
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: spencer.howells@…, raoul@… Blocked By:
Blocking: Tester: Samuel Jackson

Description (last modified by Ricardo Leal) (diff)

Nexus loader for the Back Scatering instrument IN16B.

Ticket #9337 is wating for this...

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

comment:2 Changed 7 years ago by Yannick Raoul

  • Status changed from assigned to inprogress

Re #9013 Exclude Indirect from LoadILL

Changeset: 30c3e0afc3686ba7c008c2d83127fbe1cea0a46b

comment:3 Changed 7 years ago by Yannick Raoul

Re #9013 Loader for ILL IN16B

Changeset: cc56bc9312884967ddbe9ff519efdc2a0dbe2212

comment:4 Changed 7 years ago by Yannick Raoul

comment:5 Changed 7 years ago by Yannick Raoul

Re #9013 correct monitor distance

Changeset: 6b1234d4d8a0c055bcf39688e3e9f29084e1d57b

comment:6 Changed 7 years ago by Ricardo Leal

  • Cc spencer.howells@… added

comment:7 Changed 7 years ago by Yannick Raoul

Re #9013 Added facility to logs

Changeset: 0fa11f244357e67bcb6c6eb0e5aba13d2dbbac90

comment:8 Changed 7 years ago by Ricardo Leal

  • Cc raoul@… added

comment:9 Changed 7 years ago by Yannick Raoul

Re #9013 move routine to LoadHelper.cpp

Changeset: 0a0143f9e532d66149391613ea98f4bbc2e8f409

comment:10 Changed 6 years ago by Ricardo Ferraz Leal

Re #9013 Refactoring to mantind code style.

Changeset: f19b35fef01571b3fc5de338d1467fcf05cfe11c

comment:11 Changed 6 years ago by Ricardo Ferraz Leal

Re #9013 Refactoring. Date converted to Mantid format.

Changeset: f40a3854757d75b59496d21d4a6ff6d1c765a641

comment:12 Changed 6 years ago by Ricardo Ferraz Leal

Re #9013 Fix Doxygen warning.

Changeset: bd0975bf5b0217328fb9aaf3dbfbe8ed30a696bb

comment:13 Changed 6 years ago by Ricardo Leal

To Test this loader open the file:

Test/AutoTestData/ILL/ILLIN16B_034745.nxs 

No units should be present.

The "show logs" should all the fields of the nexus file.

comment:14 Changed 6 years ago by Ricardo Leal

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Description modified (diff)

comment:15 Changed 6 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:16 Changed 6 years ago by Samuel Jackson

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Everything works as expected, but there's a block of commented out code from lines 126 to 136 that looks as though it was used for debugging and should probably be removed. Remove it and I'd be happy to pass this ticket.

comment:17 Changed 6 years ago by Ricardo Ferraz Leal

  • Status changed from reopened to inprogress

Re #9013 Removed commented out debug code.

Changeset: b47e4038251ddb771ee98505361b915b2e1f971b

comment:18 Changed 6 years ago by Ricardo Leal

Thanks for pointing this out. Debug code was removed as requested.

comment:19 Changed 6 years ago by Ricardo Ferraz Leal

  • Status changed from inprogress to closed

Merge branch 'feature/9013_load_ill_indirect' of github.com:mantidproject/mantid into feature/9013_load_ill_indirect

Full changeset: d1226cdac6f3f7b90d0619f950d443864ff044b7

comment:20 Changed 6 years ago by Samuel Jackson

Merge remote-tracking branch 'origin/feature/9013_load_ill_indirect'

Full changeset: ea39f577de6bd459211378edc514cbe8f38e4742

comment:21 Changed 6 years ago by Samuel Jackson

Refs #9013 Missed namespace declaration.

Changeset: bf57e31d0190015adce9b28453c341c6d59b1c87

Last edited 6 years ago by Samuel Jackson (previous) (diff)

comment:22 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9856

Note: See TracTickets for help on using tickets.