Ticket #9337 (closed: fixed)
ILL IN16B Reduction
Reported by: | Samuel Jackson | Owned by: | Samuel Jackson |
---|---|---|---|
Priority: | major | Milestone: | Release 3.2 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | spencer.howells@… | Blocked By: | |
Blocking: | Tester: | Peter Parker |
Description
Spencer has been working on a script that allows us to use LoadILLIndirect to perform a reduction on IN16B data. In his own words:
IN16 is an indirect spectrometer which now has its raw data in NXS format. ILL computing group have written the algorithm LoadILLindirect to read it. The Python algorithm IndirectILLreduction uses that alg to read the raw data & converts it into Energy Transfer. It is based on the Indirect Load Ascii procedures.
The new IN16B has a second method of collecting data which they call 'mirror sense' so there are 2 modes of operation. Up to now the instrument control program has not been creating a >parameter in the NXS file to specify which mode is used. This will change soon.
The main procedure is ILLindirect in IndirectNeutron.py and is called from IndirectILLreduction. The raw NXS file names do not have an instrument prefix just the number. IndirectILLreduction reads this and creates a WS called IN16_<runnumber>_raw and adds the mirror sense option to the Sample Logs.
The routine requires 2 extra files in the Instrument directory: the IPF IN16B_silicon_111_Parameters.xml for analyser data & IN16B_groups.map for the alg GroupDetectors.
Testing.
- For normal mode, Py file IN16_normal.py & data files 042385.nxs
- For mirror sense, Py file IN16_mirror.py & data file 034745.nxs
Future: the interface Load Ascii can be used. The nxs file is selected >& read using LoadILLindirect. The instrument is obtained from the SampleLog to give the choice of analyser & to rename as IN16_<runnumber>_raw and ILLindirect is called.
This ticket is to bring this functionality within Mantid.
Attachments
Change History
comment:2 Changed 6 years ago by Samuel Jackson
- Owner set to Samuel Jackson
- Status changed from new to assigned
comment:3 Changed 6 years ago by Samuel Jackson
- Component changed from Framework to Indirect Inelastic
comment:4 Changed 6 years ago by Samuel Jackson
- Status changed from assigned to inprogress
Refs #9337 Add IN16B reduction script.
Changeset: 1cda7d8ca9222378c633f8c9d898fbb5210726cd
comment:5 Changed 6 years ago by Samuel Jackson
Refs #9337 Add unit test for algorithm
Changeset: 5a7f70d267808deb6d06898fdf7bddcb6640becd
comment:6 Changed 6 years ago by Samuel Jackson
Refs #9337 Add system tests for reduction.
Changeset: d0cb93a2e4f6fa596e0ffebcbf4d21cfba7baadc
comment:7 Changed 6 years ago by Samuel Jackson
To Test
There's a new algorithm, called IndirectILLReduction. I've added a test script to run the algorithm. You should:
- Check the unit/system tests are passing
- Run the test script and check the algorithm works
- Try running in mirror mode
- Play with the different parameters and check they work.
comment:8 Changed 6 years ago by Samuel Jackson
Refs #9337 Fix documentation.
Changeset: 71a99bb8d22ea776b19734959a7c9bf55d724a80
comment:9 Changed 6 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:11 Changed 6 years ago by Jay Rainey
- Status changed from verify to reopened
- Resolution fixed deleted
Needs re-merged to develop.
comment:12 Changed 6 years ago by Samuel Jackson
- Status changed from reopened to inprogress
Refs #9337 Add documentation.
Changeset: d0b84a9ecc4e513da623e31f6aed9e57b566e35e
comment:13 Changed 6 years ago by Samuel Jackson
Refs #9337 Simplify default naming scheme
Changeset: 0e011532cfc04dc96800ebeea96b2816da5a945e
comment:14 Changed 6 years ago by Samuel Jackson
Refs #9337 Better unit testing for algorithm.
Changeset: 7af2c602c93bdc6b8d91bf96b280d2c6a6771041
comment:15 Changed 6 years ago by Samuel Jackson
Refs #9337 Fix sphinx warnings on develop.
Changeset: 60203312ba927fc4d786332e0fc252e573285ab2
comment:16 Changed 6 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:17 Changed 6 years ago by Samuel Jackson
- Status changed from verify to reopened
- Resolution fixed deleted
comment:18 Changed 6 years ago by Samuel Jackson
- Status changed from reopened to inprogress
Refs #9337 Fix plotting and make left and right ws names non optional.
Changeset: 047844ed724ccf12ab600e4077c340f1e7150971
comment:19 Changed 6 years ago by Samuel Jackson
Refs #9337 Update unit tests to match.
Changeset: cbdb9f0390d939be795813e7f1f96d8aa8667651
comment:20 Changed 6 years ago by Samuel Jackson
Refs #9337 Add system tests for reduction.
Changeset: d0cb93a2e4f6fa596e0ffebcbf4d21cfba7baadc
comment:21 Changed 6 years ago by Samuel Jackson
Refs #9337 Fix broken usage test.
Changeset: 616f86345ee4ee3ff4502319704aad5e3fa52f68
comment:22 Changed 6 years ago by Samuel Jackson
Refs #9337 Show all plots in one window.
Changeset: fd99f3ccee07f04b27e2c580048c1cf186e2ddd0
comment:23 Changed 6 years ago by Samuel Jackson
Refs #9337 Fix axis labels and title.
Changeset: 2260935f3cefbfa557c96fd06382b13402f22db2
comment:24 Changed 6 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
To Test: See comment 7
Remember to merge both the main repo and system tests
comment:25 Changed 6 years ago by Peter Parker
- Status changed from verify to verifying
- Tester set to Peter Parker
comment:26 Changed 6 years ago by Peter Parker
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9337_IN16b_reduction'
Full changeset: 43071b8f4b39c4707309be2fb8c39565ed98f979
comment:27 Changed 6 years ago by Peter Parker
Looks good to me. Tests passing and the rst documentation is there. I had a play with the script as well as the algorithm dialog and both work fine.
One slight niggle would be that we should move the old-style *WIKI* string from the top of the file to the new-style summary method, as per, for example, LoadVesuvio.py. Also, at around line 200 in IndirectILLReduction.py you have
x = mtd[right_ws].readX(0)
which can be deleted.
comment:28 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10180