Add Monitor info to LoadILL

[Ricardo Leal]

Monitor info is missing in the LoadILL. To date the monitor data in the nexus file is ignored and the monitor tag is absent in the IDF.

Monitor tag must be added for IN4, 5 and 6 IDFs. Monitor data must be read from the NeXus file and assigned to the workspace.

Also, there's no TOF information at the ILL. As for the detectors, this must be computed in real time (from distances, channel width and Ei) for the monitor.

Information for testing will be added soon.

[Ricardo Ferraz Leal]

Re #9336 Added monitors to IDF

Changeset: a36d39b3b245dabf6061fcf481fe836562a39fe9

[Ricardo Ferraz Leal]

Re #9336 Monitor data are stored in the WS.

Changeset: 47d259ad697a9d16ee3f37da0d5b763b53622eb9

[Ricardo Ferraz Leal]

Re #9336 Calculate distance source monitor.

Changeset: 6fae753aef7bddd9100fd2bf3d5b7c3483bda6a4

[Ricardo Ferraz Leal]

Re #9336 Added some fake tof correction for monitor. To check.

Changeset: 79ac267bb3888e1385c341c4ade6222a5b21a3c8

[Nick Draper]

This ticket could do with a bit more description, it will help the tester understand the aim of the ticket

[Ricardo Ferraz Leal]

Re #9336 Fix IDF: 2theta constant across same vertical detectors

Changeset: dc8d273fb1ffd7ddf4dd914051dff44724f5bc48

[Ricardo Ferraz Leal]

Re #9336 Adding nexus fields as properties. Still error in old files.

Changeset: 9885fd5118c12d574f427db5095c0605fa06289a

[Ricardo Ferraz Leal]

Re #9336 Refactoring old functions. TODO:Still error in old files.

Changeset: 89ecbddcea92350402f9b593794bb03f166929da

[Yannick Raoul]

Re #9336 Fix add nexus fields as properties for old ill files

Changeset: 22ee8213a76c1c2f582fc8e837a2dad01dde805b

[Ricardo Ferraz Leal]

Re #9336 Monitor binning equal to detector binning.

Changeset: bf9c5f0d16d72cc8432e750d4644d5cba2876f4e

[Ricardo Ferraz Leal]

Re #9336 Added new doc format.

Changeset: f37303b1ecb3b79ed3c7244f40a56dea020e648a

[Ricardo Ferraz Leal]

Re #9336 Fix merge with master.

Changeset: 310e760a302a6864ca93a36525e871a515d48262

[Ricardo Ferraz Leal]

Re #9336 Removed wiki description.

Changeset: 56e6a850033e58cf4bf50aa8016c66c4b9059a18

[Ricardo Ferraz Leal]

Re #9336 Fix merge with master.

Changeset: 7ec463151c25517ed33f63b82f46c87cff3be46d

[Ricardo Ferraz Leal]

Re #9336 fix conflicts with Yannick push

Changeset: c8d4d49097d74701cfc5ec6f74e5ad08d4c10885

[Ricardo Ferraz Leal]

Re #9336 New rst doc for indirect.

Changeset: d23ebaf49a8ed023e3d4751bffe3f06d46dc24ee

[Ricardo Ferraz Leal]

Re #9336 Fix merge with develop.

Changeset: 9ef2d2cbc2a5215b9f6bd4539bc62d6ac7521a7d

[Ricardo Ferraz Leal]

Re #9336 Added monitors to the test

Changeset: 65d7f144020e33b418ff07b2171efd48c08d7fee

[Ricardo Leal]

Monitor added:

To test:

Load the file:

Test/AutoTestData/ILLIN5_104007.nxs

One monitor should be visible in the data.

Note:

There's also a merge to be done in the system tests:

~/git/systemtests [feature/9336_Add_monitor_to_LoadILL]
#	modified:   SystemTests/AnalysisTests/LoadILLIN5Test.py

[Ricardo Ferraz Leal]

Re #9336 Fix Doxygen warnings

Changeset: 11229c91ad3f597013b95b9ba9d62e0ac60082b2

[Ricardo Ferraz Leal]

Re #9336 fix conflict with master

Changeset: 5288dda2a4d11ccc7dc42fd7079f2329b24b373f

[Ricardo Ferraz Leal]

Re #9336 fix conflict with develop

Changeset: 834d417d4228fd0f691af6c59d43919c9d0857f4

[Ricardo Ferraz Leal]

Re #9336 Add last versions of LoadHelper

Changeset: c6531a5b41fa9a126745ade5f6f33e985af5cd8d

[Ricardo Ferraz Leal]

Re #9336 Fix merge LoadHelper

Changeset: 4a8d644c31eb49a3d1983b7a8efb356e0ce51730

[Owen Arnold]

I'm having trouble with this. No detectors are marked as monitors:

ws = Load('ILLIN5_104007.nxs')
for i in range(ws.getNumberHistograms()):
        if ws.getDetector(i).isMonitor():
                print i
                break

prints nothing. I might be doing something stupid please advise.

[Ricardo Leal]

Just loaded the same file in MantidPlot (same branch) and got the '0' detector printed out:

In [1]: ws = mtd['ILLIN5_104007']

In [2]: for i in range(ws.getNumberHistograms()):
   ...:     if ws.getDetector(i).isMonitor():
   ...:         print i
   ...:         
0

In [3]: 

My branch is uptodate:

08:50 $ git pull origin feature/9336_Add_monitor_to_LoadILL
From github.com:mantidproject/mantid
 * branch            feature/9336_Add_monitor_to_LoadILL -> FETCH_HEAD
Already up-to-date.

Let me know if I can help.

[Yannick Raoul]

Merge branch 'feature/9336_Add_monitor_to_LoadILL' of github.com:mantidproject/mantid into feature/9336_Add_monitor_to_LoadILL

Full changeset: ​4a7bc14ee5ab4d4f4107e7cd940fa82b75ff43d5

[Ricardo Ferraz Leal]

Merge branch 'feature/9336_Add_monitor_to_LoadILL' of github.com:mantidproject/mantid into feature/9336_Add_monitor_to_LoadILL

Full changeset: ​6777ae4d71b9db8705f277acda98a4b3293769a4

[Owen Arnold]

Merge remote-tracking branch 'origin/feature/9336_Add_monitor_to_LoadILL'

Full changeset: ​097b03dbc16f27d383415ffbff2753e1131bb145

[Martyn Gigg]

Merge remote-tracking branch 'origin/feature/9336_Add_monitor_to_LoadILL'

Full changeset: ​e182fcaf6022bb8cc32cc8a57bd1bbb194f18b5a

[Ricardo Ferraz Leal]

Re #9336 Fix merge with develop.

Changeset: 9ef2d2cbc2a5215b9f6bd4539bc62d6ac7521a7d

[Ricardo Ferraz Leal]

Re #9336 fix conflict with develop

Changeset: 834d417d4228fd0f691af6c59d43919c9d0857f4

[Ricardo Ferraz Leal]

Re #9336 Fix merge LoadHelper

Changeset: 4a8d644c31eb49a3d1983b7a8efb356e0ce51730

[Stuart Campbell]

This ticket has been transferred to github issue ​10179