Ticket #9335 (closed: fixed)
Enable GenerateEventsFilter to output splitters in MatrixWorskpace for integer log
Reported by: | Wenduo Zhou | Owned by: | Wenduo Zhou |
---|---|---|---|
Priority: | major | Milestone: | Release 3.2.1 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Roman Tolchenov |
Description (last modified by Wenduo Zhou) (diff) ¶
Enable algorithm GenerateEventsFilter to export event splitters in MatrixWorskpace format, i.e., work with option 'FastLog' for filtering by values of integer log (integer TimeSeriesProperty).
GenerateEventsFilter does not support filtering in a single log value range (LogValueInterval is not specified) with option FastLog is true. In fact, Mantid crashes at this situation. Resolve it.
Change History
comment:4 Changed 6 years ago by Wenduo Zhou
Refs #9335. Enabled to output vector splitter for integer log.
A new unit test for the new feature is added as well.
Changeset: 673223e6309340a6a3983b8d9475fa6c1a82d484
comment:5 Changed 6 years ago by Wenduo Zhou
Refs #9335. Enabled to split with single log data range to matrix.
A unit test related is added too.
Changeset: d8ce3dea7dd0b446375f0067448337620f68f876
comment:6 Changed 6 years ago by Wenduo Zhou
- Description modified (diff)
For tester
- Check the newly added unit tests for the new feature;
- Use the following script to check whether the crash is solved.
ws = Load(Filename="WISH00028816.nxs")
spliterWS, infoWS = GenerateEventsFilter(InputWorkspace=ws, FastLog=True, LogName='ORC_cycle', MinimumLogValue=522.0)
splitws2, infows2 = GenerateEventsFilter(InputWorkspace=ws, FastLog=False, LogName='ORC_cycle', MinimumLogValue=522.0)
You can compare spliterWS and splitws2 to check whether they are identical, though one of them is SplittersWorkspace, and the other is a MatrixWorkspace.
- You can find a workspace with integer log and generate events filter with option FastLog is True.
comment:7 Changed 6 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
comment:8 Changed 6 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:9 Changed 6 years ago by Roman Tolchenov
Re #9335. Fixed a bug in TimeSeriesProperty.
Changeset: 80dba5a6036275946750cd94ce89e746d416d1c4
comment:10 Changed 6 years ago by Roman Tolchenov
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9335_gen_filter_int_log'
Full changeset: 973f085cbf2235a0b20629264321b64f4ca9426e
comment:12 Changed 6 years ago by Martyn Gigg
- Keywords PatchCandidate removed
- Milestone changed from Release 3.3 to Release 3.2.1
comment:13 Changed 6 years ago by Wenduo Zhou
Cherry-pick fixes from feature/9335_gen_filter_int_log into next
Changes:
Refs #9335. Enabled to output vector splitter for integer log.
A new unit test for the new feature is added as well. (cherry picked from commit 673223e6309340a6a3983b8d9475fa6c1a82d484)
Refs #9335. Enabled to split with single log data range to matrix.
A unit test related is added too. (cherry picked from commit d8ce3dea7dd0b446375f0067448337620f68f876)
Re #9335. Fixed a bug in TimeSeriesProperty. (cherry picked from commit 80dba5a6036275946750cd94ce89e746d416d1c4)
Changeset: be4e57276efdd5c1747917b6b125f7f8ece01f1a
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10178