Ticket #9338 (closed: fixed)
IDA: Consistent Miniplot spectrum selection
Reported by: | Samuel Jackson | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | major | Milestone: | Release 3.3 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | spencer.howells@… | Blocked By: | #10140 |
Blocking: | Tester: | Anders Markvardsen |
Description
Many places in the IDA interface allow the user to choose a the spectrum and range used in fitting, but they are inconsistent. Modify the interfaces so that they work like #4856 with a index for the spectrum to plot and a range of spectra to use in the fitting.
Attachments
Change History
comment:4 Changed 6 years ago by Dan Nixon
- Status changed from assigned to inprogress
Made spectra options more consistent for conv and fury fit
Refs #9338
Changeset: 356357f6959355f25fd9bf94a0a593a377e7e9c5
comment:5 Changed 6 years ago by Dan Nixon
Added spectra range selection to fury fit
Also a spelling correction
Refs #9338
Changeset: 6fd0591f20775f242423efb7dbaf304482919505
comment:6 Changed 6 years ago by Dan Nixon
- Blocked By 10140 added
The UI changes conflict with this ticket.
comment:7 Changed 6 years ago by Dan Nixon
Merge branch 'master' into bugfix/9338_consistent_ida_miniplot_spectra_options
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataAnalysis.ui Code/Mantid/scripts/Inelastic/IndirectDataAnalysis.py
Refs #9338
Changeset: 1c94c78778287069930b6878b29603dee5dba7f7
comment:8 Changed 6 years ago by Dan Nixon
Handle max and min spectra indexes, correct merge errors
Refs #9338
Changeset: ebf6a5a8eb60d835ab4617c18e8fe78c09f910ce
comment:9 Changed 6 years ago by Dan Nixon
Fixed ConvFit sequential naming issue
Refs #9338
Changeset: 2917895d8cad669fc547e0e927b168aca8f9a317
comment:10 Changed 6 years ago by Dan Nixon
Use correct number of histograms in FuryFit seq
Refs #9338
Changeset: c94747beb5f54bc7ab40e1605195f589c15a8592
comment:12 Changed 6 years ago by Dan Nixon
comment:13 Changed 6 years ago by Dan Nixon
comment:14 Changed 6 years ago by Dan Nixon
Fix failure when no spec_max is given to FuryFit
Refs #9338
Changeset: 4bdc48f99473b816302aa1ae3430fc3e5db5b3ac
comment:15 Changed 6 years ago by Dan Nixon
Remove _s from fit_type in fury fit result WS logs
Refs #9338
Changeset: c66cdfc9c6360880a09b4318027a4de78634bb80
comment:16 Changed 6 years ago by Dan Nixon
ConvFit FWHM default to instrument resolution
Refs #9338
Changeset: 8cac9160391a0209b562c9ffed650a3261f11bee
comment:17 Changed 6 years ago by Dan Nixon
Load analyser component if it is not in the file
Refs #9338
Changeset: 53820f890e8ff9c88c80a9526b30eca4cd50fa2d
comment:18 Changed 6 years ago by Dan Nixon
To test:
- Open Indirect >> Data Analysis >> ConvFit
- Set the fit type to "One Lorentzian", notice the default FWHM value of 0.2
- Open the sample file "irs26176_graphite002_red.nxs" and resolution file "irs26176_graphite002_res.nxs" from system test data
- Notice the FWHM value defaults to the resolution of the instrument and analyser (0.0175 for graphite on IRIS)
- Experiment with the plot spectrum option for fitting the current spectrum shown in the mini plot
- Experiment with the spectra range options for defining a set of spectra to fit, in particular: try entering values outside the spectra range of the WS, define a range starting after the first spectrum and ending before the last spectrum (e.g. 2-7).
- Switch to the fury fit tab and open the attached nexus file, be sure to set the EndX value (e.g. 0.2)
- Repeat steps used to test ConvFit
Changed 6 years ago by Dan Nixon
- Attachment irs26176_graphite002_iqt.nxs added
File for testing FuryFit
comment:19 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
comment:20 Changed 6 years ago by Anders Markvardsen
- Status changed from verify to verifying
- Tester set to Anders Markvardsen
comment:21 Changed 6 years ago by Dan Nixon
- Status changed from verifying to closed
Merge branch 'master' into bugfix/9338_consistent_ida_miniplot_spectra_options
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataAnalysis.ui Code/Mantid/scripts/Inelastic/IndirectDataAnalysis.py
Refs #9338
Full changeset: 1c94c78778287069930b6878b29603dee5dba7f7
comment:22 Changed 6 years ago by Anders Markvardsen
Merge remote-tracking branch 'origin/bugfix/9338_consistent_ida_miniplot_spectra_options'
Full changeset: 5ff1db39c544481d462dabaa772f342dc2fcc137
comment:23 Changed 6 years ago by Anders Markvardsen
improved consistency.
for information note that default fwhm was 0.02 and perhaps because I was not updated systemtest repository recently irs26176_graphite002_res.nxs did not exist but irs26173_graphite002_res.nxs did
comment:24 Changed 6 years ago by Dan Nixon
Missing systemtest commit: c27b605f281c82b82df27b216c0d83b7fa9bb3b9
comment:25 Changed 6 years ago by Anders Markvardsen
Merge remote-tracking branch 'origin/bugfix/9338_consistent_ida_miniplot_spectra_options'
Full changeset: 1b961cba0c5b946bbc2410b4368e81dbfe252544
comment:26 Changed 6 years ago by Dan Nixon
Merge branch 'master' into bugfix/9338_consistent_ida_miniplot_spectra_options
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataAnalysis.ui Code/Mantid/scripts/Inelastic/IndirectDataAnalysis.py
Refs #9338
Full changeset: 1c94c78778287069930b6878b29603dee5dba7f7
comment:27 Changed 6 years ago by Anders Markvardsen
Merge remote-tracking branch 'origin/bugfix/9338_consistent_ida_miniplot_spectra_options'
Full changeset: 5ff1db39c544481d462dabaa772f342dc2fcc137
comment:28 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10181