Ticket #9339 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

IDA: Swap sequential run and run buttons

Reported by: Samuel Jackson Owned by: Dan Nixon
Priority: minor Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Samuel Jackson

Description

Currently there are a number of places in the IDA interface that allow you to run both a single and sequential fit. These buttons should be swapped so that the sequential fit option is the main button on the interface for all tabs (because this is what you'll want to do 90% of the time).

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Owner changed from Samuel Jackson to Dan Nixon
  • Status changed from new to assigned
  • Milestone changed from Backlog to Release 3.3

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Swapped Fit and Fir Sequential buttons

On IDA the main Run button now fits all spectra

Refs #9339

Changeset: f0ef28f4c5221a9061f6484c098d105a8c4e1e36

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test:

  • Ensure that MSD Fit, FuryFit and ConvFit run as they did in Mantid 3.2
  • Ensure that selecting "Run" fits all spectra while selecting "Fit Single Spectra" fits only the spectra shown in on the mini plot

comment:4 Changed 6 years ago by Samuel Jackson

  • Status changed from verify to reopened
  • Resolution fixed deleted

I tried running single ConvFit without specifying a Lorentzian or Delta function and I get a crash. Before I got an error message, which you still get if you do the same thing but run it sequentially.

comment:5 Changed 6 years ago by Dan Nixon

  • Status changed from reopened to inprogress

Added validation to sequential fit buttons

Removed assertions

Refs #9339

Changeset: c7d7d2d967915d2e47ad9265c5536283ebce1be7

comment:6 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 6 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:8 Changed 6 years ago by Samuel Jackson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9339_swap_fit_and_fit_sequential_buttons'

Full changeset: ​190fa1219f37ed6a7f64e5b5c9db0072f8692f7f

comment:9 Changed 6 years ago by Samuel Jackson

Looks good. Remember to loudly publicise the difference when you come to write the release notes. They'll get confused otherwise :)

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10182

Note: See TracTickets for help on using tickets.