Ticket #9108 (closed: fixed)
SCDCalibratePanels error
Reported by: | Vickie Lynch | Owned by: | Vickie Lynch |
---|---|---|---|
Priority: | major | Milestone: | Release 3.2 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #9143 | Tester: | Peter Peterson |
Description
Error message when tried to run SCDCalibratePanels in mantidplot:
SCDCalibratePanels started
Error in execution of algorithm SCDCalibratePanels:
Not a valid attribute name "SampleX"
Change History
comment:2 Changed 7 years ago by Vickie Lynch
Test script:
Load(Filename='TOPAZ_3007.peaks',OutputWorkspace='TOPAZ_3007') SCDCalibratePanels(PeakWorkspace='TOPAZ_3007',PanelGroups='SpecifyGroups',Grouping='26',a='14',b='19.300000000000001',c='8.5999999999999996',alpha='90',beta='105',gamma='90',useL0='0',usetimeOffset='0',usePanelWidth='0',usePanelHeight='0',usePanelPosition='0',usePanelOrientation='0',AllowSampleShift='1',DetCalFilename=r'/home/vel/mantid/Code/release/bin/topaz.detcal',ResultWorkspace='Result',QErrorWorkspace='QErrorResults')
comment:4 Changed 7 years ago by Vickie Lynch
- Status changed from assigned to verify
- Resolution set to fixed
comment:5 Changed 7 years ago by Vickie Lynch
- Status changed from verify to reopened
- Resolution fixed deleted
Only moves sample for group 1?
comment:6 Changed 7 years ago by Vickie Lynch
- Status changed from reopened to verify
- Resolution set to fixed
Sample position is changed for all groups, but detector offsets are different for each group:
Load(Filename='TOPAZ_3007.peaks',OutputWorkspace='TOPAZ_3007') SCDCalibratePanels(PeakWorkspace='TOPAZ_3007',a='14',b='19.300000000000001',c='8.5999999999999996',alpha='90',beta='105',gamma='90',useL0='0',usetimeOffset='0',usePanelWidth='0',usePanelHeight='0',usePanelOrientation='0',AllowSampleShift='1',PreProcFilename=r'/home/vel/mantid/Code/release/bin/topaz.detcal',DetCalFilename='topaz.detcal',ResultWorkspace='Result',QErrorWorkspace='QErrorResults')
comment:7 Changed 7 years ago by Peter Peterson
- Status changed from verify to verifying
- Tester set to Peter Peterson
comment:8 Changed 7 years ago by Peter Peterson
- Status changed from verifying to reopened
- Resolution fixed deleted
Does the if statement at line 292 need to get changed to
if( SampleOffsets) { SampOffsetDeclareStatus = 2; }
Also, shouldn't the bit at line 435 always get the sample offsets, but not refine them?
comment:9 Changed 7 years ago by Vickie Lynch
Hi Pete, For your last suggestion about sample offsets, do you want parameters added so the user can specify sample offsets?
comment:10 Changed 7 years ago by Peter Peterson
I think that was always the intent. Otherwise the sample offsets would always have to be refined during the last step.
comment:11 Changed 7 years ago by Vickie Lynch
- Status changed from reopened to inprogress
Refs #9108 input parameters for sample offset
Changeset: f8fb67a6983423a1e03f253a288c364400a108ca
comment:12 Changed 7 years ago by Vickie Lynch
- Status changed from inprogress to verify
- Resolution set to fixed
comment:14 Changed 7 years ago by Peter Peterson
- Status changed from verifying to closed
Merge remote branch 'origin/feature/9108_SCDCalibratePanels_error'
Full changeset: 467886d402547cc64a049875cebeb8235938f9a4
comment:15 Changed 7 years ago by Owen Arnold
These changes have caused the windows debug builds to fail. This relates to this changeset https://github.com/mantidproject/mantid/commit/f8fb67a6983423a1e03f253a288c364400a108ca see report here http://download.mantidproject.org/jenkins/view/Develop%20Clean%20Builds%20and%20Tests/job/is_clean_win7_develop_db/176/
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9951
Refs #9108 add sample positions to attributes
Changeset: 817e8a585c273a2349df46e0eec3dea12afed015