Ticket #9109 (closed: duplicate)

Opened 7 years ago

Last modified 5 years ago

Reflectometry 3.1.1 issue to investigate - Possible defect

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: blocker Milestone: Release 3.2
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

See below. This is probably due to changes made to Stitch1D. I'm confident that changes made to Stitch1D and Stitch1DMany were for the better, but it could be due to auxiliary workspaces not sitting around in the ADS. Needs investigation in any case.

Hi Owen,

3.1.1 seems to have broken a previously working script on the line

DataOut=CloneWorkspace(GroupWorkspaces([nIp, nIa]))

The error dump is included below.  

This is part of the polarization corrections that I coded to test ReflectometryReductionOneAuto and may be obsolete by now.  Do you have a replacement/ workaround/ fix? 

Many thanks,  
Tim
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
<ipython-input-2-f611aa3039dc> in <module>()
      4 
      5 from mantid.simpleapi import *
----> 6 from WrappedReduction import *

u:\user\mantid\TestingPointDetectorReduction\WrappedReduction.py in <module>()
    353 
    354 #####################        M2-0167 T=5K
--> 355 ( _ ,r1q , _)= ref('8169+8171+8173+8175+8177+8179+8181',theta=0.4)
    356 
    357 print r1q

u:\user\mantid\TestingPointDetectorReduction\WrappedReduction.py in ref(RunNumbers, theta)
    325         trans=CorrectMonitor(trans)
    326         (_,rl,ThetaOut)=ReflectometryReductionOneAuto(InputWorkspace=dd,I0MonitorIndex='2',ProcessingInstructions='3',ThetaIn=theta,FirstTransmissionRun=trans,StrictSpectrumChecking=False)
--> 327         RcorrectedVsLambda = CorrectPolarization(rl)
    328         RcorrectedVsQz = RcorrectedVsLambda.convertUnits('MomentumTransfer')
    329         return RcorrectedVsQz, RcorrectedVsLambda, ThetaOut

u:\user\mantid\TestingPointDetectorReduction\WrappedReduction.py in CorrectPolarization(TheDataIn)
    281                 nIa = ( Ip * (rho * Pp - 1.0) + Ia * (Pp + 1.0) ) / D
    282                 #print "nIp,nIa ",nIp, nIa
--> 283                 DataOut=CloneWorkspace(GroupWorkspaces([nIp, nIa]))
    284                 return DataOut
    285 

C:\MantidInstall\bin\mantid\simpleapi.pyc in algorithm_wrapper(*InputWorkspaces, **Version=1)
    565 
    566         _set_properties(algm, *args, **final_keywords)
--> 567         algm.execute()
    568         return _gather_returns(algorithm, lhs, algm)
    569 

RuntimeError: Some invalid Properties found

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned
  • Milestone changed from Backlog to Release 3.2

comment:2 Changed 7 years ago by Owen Arnold

  • Status changed from assigned to verify
  • Resolution set to duplicate

I have spoken to Martyn about this. This is because the python API seems to be 100% pythonic, but actually isn't. A better description is here. http://trac.mantidproject.org/mantid/ticket/9111

comment:3 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:4 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

comment:5 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9952

Note: See TracTickets for help on using tickets.