Ticket #9110 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Dead Time correction with zero frames_good

Reported by: Arturs Bekasovs Owned by: Arturs Bekasovs
Priority: major Milestone: Release 3.2
Component: Muon Keywords:
Cc: stephen.cottrell@… Blocked By: #9129
Blocking: Tester: Martyn Gigg

Description

If the frames_good in the file is 0, using ApplyDeadTimeCorr on it produces a workspaces with 0 or NaN values. The file attached is an example of such situation.

The solution is to fail ApplyDeadTimeCorr in that case, as agreed by Steve.

In MuonAnalysis, failed ApplyDeadTimeCorr is not considered a critical error so we should be able to load the data anyway. Make sure the warning is shown though, so the user is aware of what has happened.

Attachments

HIFIauto_C.tmp.nxs​ (1.2 MB) - added by Arturs Bekasovs 7 years ago.
Muon Nexus file with frames_good = 0

Change History

Changed 7 years ago by Arturs Bekasovs

Muon Nexus file with frames_good = 0

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 7 years ago by Arturs Bekasovs

  • Status changed from assigned to inprogress

Refs #9110. Fail ApplyDeadTimeCorr if goodfrm is zero

Changeset: 13b9e1a2edd9ad95658effed0710f900a45ff085

comment:3 Changed 7 years ago by Arturs Bekasovs

  • Blocked By 9129 added

Need improve error messages returned when execution on groups fail first. This is not really informative:

No dead time correction applied: Execution of ApplyDeadTimeCorr for group entry 1 failed

comment:4 Changed 7 years ago by Arturs Bekasovs

  • Status changed from inprogress to verify
  • Resolution set to fixed

Tester:

Try to load the attached file in MuonAnalysis, setting Dead Time Correction type to "From Data File". The workspace should be loaded fine, though without Dead Time Correction applied, which should be explained in an informative log message.

comment:5 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:6 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9110_muon_dtc_with_zero_frmgood'

Full changeset: ​d1d8cd5b2b72e3fbd710cebb608385c1a461e759

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9953

Note: See TracTickets for help on using tickets.