Ticket #9119 (closed: fixed)
Fix Coverity issues
Reported by: | Arturs Bekasovs | Owned by: | Arturs Bekasovs |
---|---|---|---|
Priority: | major | Milestone: | Release 3.2 |
Component: | Muon | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Russell Taylor |
Description
There a few issues in MuonAnalysis / MuonAnalysisHelper as reported by Coverity. Should fix those.
Change History
comment:3 Changed 7 years ago by Arturs Bekasovs
- Status changed from assigned to inprogress
Refs #9119. Restore format of the stream.
Changeset: 8a9402964b7a561fbbb8ea91663428e58bf027af
comment:4 Changed 7 years ago by Arturs Bekasovs
Refs #9119. Fix "Dereference after null-check" errors
Changeset: 95bbfa8c3bd5779bf83846c1bb055098010877d0
comment:5 Changed 7 years ago by Arturs Bekasovs
Refs #9119. Add missing member initializations
Changeset: a31f028570e346e261188c2e8d0638df7b294125
comment:6 Changed 7 years ago by Arturs Bekasovs
- Status changed from inprogress to verify
- Resolution set to fixed
Tester:
Unfortunately, Coverity checks are run as infrequent as once a week and checkout master branch only. So the only way to verify these changes is to read through the code, make sure the changes appear to be harmless and relate to warnings reported by Coverity in appropriate files. You can view reported warnings here: https://scan.coverity.com/projects/335/view_defects. If the warning will not be solved after this gets to master, I'll open another ticket and try it again.
comment:7 Changed 7 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:8 Changed 7 years ago by Russell Taylor
- Status changed from verifying to closed
Merge remote branch 'origin/bugfix/9119_muon_coverity_issues'
Full changeset: 1497c8f77526e3170522b06b21b0459f0f641c51
comment:9 Changed 7 years ago by Russell Taylor
Results from the next coverity analysis will probably be available some time on Monday.
comment:10 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9962
Stream state can be easily restored like described here: http://stackoverflow.com/questions/2273330/restore-the-state-of-stdcout-after-manipulating-it