Ticket #9120 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Seq. fit dialog: waiting for file search to finish is not working properly

Reported by: Arturs Bekasovs Owned by: Arturs Bekasovs
Priority: major Milestone: Release 3.2
Component: Muon Keywords:
Cc: Blocked By:
Blocking: Tester: Jay Rainey

Description

To reproduce:

  1. Load MUSR00015189 in MuonAnalysis.
  2. Set fit model on Data Analysis tab.
  3. Run the seq. fit dialog.
  4. Type "15189-15199" to the Runs field.
  5. Without clicking anywhere else, press Run.

The dialog waits for file search to finish, but when it does, the error is thrown. Pressing Run again starts the fit.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 7 years ago by Arturs Bekasovs

  • Status changed from assigned to inprogress

Refs #9120. Process events after the search is finished

After the file searching thread is finished, it emits some signals which MWRunFiles needs to process before we can access the found files. We are now doing that by calling QApplication::processEvent() after the search process has finished.

Changeset: fe189e17487c4e3a17a12438ad590f0f23c4a952

comment:3 Changed 7 years ago by Arturs Bekasovs

Tester:

Make sure the problem is not reproducible any more. You should be able to just type in a run range and press Run button (or Return key) and the fitting process should begin after (and if) the files were found.

You might want to use the archive to make the search time noticeable.

comment:4 Changed 7 years ago by Arturs Bekasovs

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:5 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:6 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to closed

The issue is no longer reproducible. I can now enter a run and press enter (or click Run) without the error message appearing. I entered valid runs to verify that the changes fixed the issue. I also entered invalid runs to ensure the error box would appear when it should. This was done both locally and using the archives. The changes made are sensible.

comment:7 Changed 7 years ago by Jay Rainey

Merge remote-tracking branch 'origin/bugfix/9120_muon_seq_fit_file_search_finish'

Full changeset: dbc293a8eb800d5ca8e2ce7c5d5eea86a9ae8c70

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9963

Note: See TracTickets for help on using tickets.