Ticket #9121 (closed: fixed)
New algorithm to determine powder characterization runs
Reported by: | Peter Peterson | Owned by: | Peter Peterson |
---|---|---|---|
Priority: | major | Milestone: | Release 3.2 |
Component: | Diffraction | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #8675 | Tester: | Wenduo Zhou |
Description
As part of #8675, create a workflow algorithm, PDDetermineCharacterizations, to handle the business of determining which characterization runs should be used. This will take in a workspace (only needing logs) for the sample run, and a table workspace produced by LoadPDCharacterizations (#8623) and return 3 values: background run number, vanadium run number, vanadium background run number.
Change History
comment:2 Changed 7 years ago by Peter Peterson
- Status changed from assigned to inprogress
Re #9121. Very empty version of the algorithm.
Changeset: a6557c435639121004ea322527d348125488760e
comment:3 Changed 7 years ago by Peter Peterson
Re #9121. Added init and validateInputs.
Changeset: 413419cbc850feae692b171b5c14489633f0750f
comment:4 Changed 7 years ago by Peter Peterson
Re #9121. Adding code to determine frequency and wavelength.
Changeset: 4c389dcba6204f122db59681b97fba1ef35572a6
comment:5 Changed 7 years ago by Peter Peterson
Re #9121. Migrated to filling in a property manager.
Changeset: cad06be245bdb8eb82c976454a0b9a5e2e1a7e6b
comment:6 Changed 7 years ago by Peter Peterson
Re #9121. Fixed issue pointed out by unit test
Changeset: ad4d0acd3767f91e12c9fe4f99e285a7ba237b2c
comment:7 Changed 7 years ago by Peter Peterson
Re #9121. Added the ability to set the units on a Property.
Changeset: 1344fbc2ba2c2b62abc2e491a9502799297ad57c
comment:8 Changed 7 years ago by Peter Peterson
Re #9121. Adding a unit test for PDDetermineCharacterizations.
Changeset: 51640693b7e81f158bc745b380a182eaf1814f14
comment:9 Changed 7 years ago by Peter Peterson
Re #9121. Fixing bugs found by the unit test.
Changeset: 2412383bd5ecbb0e93f97e811dfa20685aa8e37d
comment:10 Changed 7 years ago by Peter Peterson
- Status changed from inprogress to verify
- Resolution set to fixed
- Tester set to Wenduo Zhou
This is on feature/9121_determine_characterizations.
To test: This one might be done best by looking at the source for the unit test. If you want to use this in anger try LoadPDCharacterizations to get a table workspace to work with.
comment:12 Changed 7 years ago by Wenduo Zhou
- Status changed from verifying to closed
The algorithms works fine.
But there are some that can be improved.
- Wiki
- InputWorkspace should be restricted to MatrixWorkspace. Now you can even (mistakenly) set a table workspace to it and get an exception thrown.
comment:13 Changed 7 years ago by Wenduo Zhou
Merge remote-tracking branch 'origin/feature/9121_determine_characterizations'
Full changeset: 755430ec37aa4bf6f4af549252928e0df336884d
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9964