Allow more complex sample and source IDF descriptions

[Anders Markvardsen]

Currently IDF does not allow IDF sample and source descriptions which contain components, i.e. is an ensemble.

Attached is a McStas generated IDF where the sample and source descriptions are components of components. Loading this file is OK but when do Show Instrument Mantid dies

Bugfix and enhance Mantid to allow arbitrary complex structure for sample and source also

[Anders Markvardsen]

mcstas generated idf

[Owen Arnold]

Sounds like a good enhancement to have.

[Anders Markvardsen]

Make IDF parser submit assembly sample comp also. re #9133

And add unit test to test that this works

Changeset: 3c6f26cde381edaa2abc61422555db96747e982a

[Anders Markvardsen]

store store as IComponent. re #9133

and added unit test to test ok

Changeset: 2db727fcf8ecb4e547c787aeabd3e92fcd80514f

[Martyn Gigg]

Update the function signatures of the Python instrument export.

Refs #9133

Changeset: 89a731104bbedbb5a2ea13df8cc6461e3ec5bea2

[Anders Markvardsen]

HRPD with complicated sample shape

[Anders Markvardsen]

HRPD with complicated sample and source shape

[Anders Markvardsen]

ALF with complicated sample and source shape

[Anders Markvardsen]

Remove SampleActor from InstrumentActor. re #9133

As discussed with Roman if ever relevant can be added again

Changeset: 7fd3bd60b0df3f7708ee8f16c33e507d5912d20b

[Anders Markvardsen]

Remove unused variable. re #9133

Changeset: fedc88c714efe8fe32f8c798a87fc169ab1fb0d8

[Anders Markvardsen]

To test:

1. check that unit tests are ok

2. Load attached HRPD_Definition_mod.xml either using Load button or LoadEmptyInstrument and you should see some blob around the origin, which is some mcstas generated sample geometry

3. Load attached HRPD_Definition_mod2.xml and/or ALF_Definition_with_source.xml, which should both display. Notice that when viewed in 3D view you will see instrument at a large distance because of the source description is far away from the rest of the instrument. we probably at some need to think about how we handle this better, but for now either zoom on sample or source to see some blob, or user Instrument tree to focus on these features

Note ignore the templateSANS.out.xml file which is ga ga

[Karl Palmen]

In 2. I do not see a blob at the origin. If I view instrument tree, I see a nickel holder with 12 components. If a select the nickel holder I do see a blob at the origin also I see parts of this blob when I select a componenents of the nickel holder. This is what I'd expect from a sample that contains components.

[Karl Palmen]

3 went as expected.

[Anders Markvardsen]

Merge remote-tracking branch 'origin/feature/9133_idf_source_shape' into feature/9133_idf_source_shape

Full changeset: ​881bb2a23ec590a6ce2653f97874b15b7e0be496

[Karl Palmen]

Merge remote-tracking branch 'origin/feature/9133_idf_source_shape'

Full changeset: ​5fcfd9663728e53bde1ca16df5189ac8b64a1644

[Stuart Campbell]

This ticket has been transferred to github issue ​9976