Ticket #9225 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Use last angles for TOPAZ goniometer

Reported by: Vickie Lynch Owned by: Vickie Lynch
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

TOPAZ_9398 has an error where the omega and phi angles are not correct at the beginning of the run. Use the last values to set goniometers not the averages in case this happens again.

Change History

comment:1 Changed 7 years ago by Vickie Lynch

This is the problem run: 

wksp=Load(Filename='TOPAZ_9398_event.nxs')
a=wksp.run().getGoniometer() 
print a.getEulerAngles('YZY')
Last edited 7 years ago by Vickie Lynch (previous) (diff)

comment:2 Changed 7 years ago by Vickie Lynch

Refs #9225 fix for TOPAZ DAS problem

Changeset: 8b5c78908529cfe9400f7f67b1b11d685f142a1f

comment:3 Changed 7 years ago by Owen Arnold

  • Status changed from new to assigned

comment:4 Changed 7 years ago by Vickie Lynch

Decision is to write warning if there is a change in log goniometer angles that includes how to SetGoniometer and print last value and mean. 

Load(Filename=r'/home/vel/workspace/TOPAZ_9398_event.nxs',OutputWorkspace='TOPAZ_9398_event')
SetGoniometer(Workspace='TOPAZ_9398_event',Axis0='1.604,0,1,0,1',Axis1='chi,0,0,1,1',Axis2='-157,0,1,0,1')
Last edited 7 years ago by Vickie Lynch (previous) (diff)

comment:5 Changed 7 years ago by Martyn Gigg

There is a compiler warning in ​Run.cpp

comment:6 Changed 7 years ago by Vickie Lynch

  • Status changed from assigned to inprogress

Refs #9225 warning instead of using last angle

Changeset: 65c5aef5a7c32862bd20b46006842335a8291738

comment:7 Changed 7 years ago by Vickie Lynch

Refs #9225 new warning message

Changeset: cd74d1f5b3dd0a7e9981251271838639588c3b5a

comment:8 Changed 7 years ago by Vickie Lynch

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test Load TOPAZ_9398 or use this script 

Load(Filename='~/systemtests/Data/HYS_13657_event.nxs',OutputWorkspace='HYS_13657_event')
SetGoniometer(Workspace='HYS_13657_event',Axis0='s1,0,1,0,1')

comment:9 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:10 Changed 6 years ago by Vickie Lynch

Refs #9225 check min and max angles

Changeset: 7316a86174320751ad55b796b93c7c73ef95de83

comment:11 Changed 6 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9225_Goniometer_last_angle_check'

Full changeset: ​2f9b3c5ccc66294cbcab5b07a8400fbd6a65ee45

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10068

Note: See TracTickets for help on using tickets.