Ticket #9226 (closed: fixed)
FilterBadPulses should error if there is no proton_charge
Reported by: | Peter Peterson | Owned by: | Peter Peterson |
---|---|---|---|
Priority: | major | Milestone: | Release 3.2 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Vickie Lynch |
Description
As this gets into a funny state that all events will be deleted when there isn't a proton charge, but the algorithm will return success. Do two checks:
- Fail if "gd_prtn_chrg" is zero. If the log is missing skip the check and warn.
- Fail if the maximum of "proton_charge" is zero.
Change History
comment:2 Changed 7 years ago by Peter Peterson
- Status changed from assigned to inprogress
Re #9226. FilterBadPulses now errors out if there isn't any pcharge.
Changeset: 1b74983708bb8af5f4f314b2f44e7139b31c84ed
comment:3 Changed 7 years ago by Peter Peterson
- Status changed from inprogress to verify
- Resolution set to fixed
This is on feature/9226_FilterBadPulses_checking.
To test: Most event files should be fine, but now things that were measured when the accelerator was down (like PG3_18104) will fail.
comment:4 Changed 7 years ago by Vickie Lynch
- Status changed from verify to verifying
- Tester set to Vickie Lynch
comment:5 Changed 7 years ago by Vickie Lynch
- Status changed from verifying to closed
Merge remote branch 'origin/feature/9226_FilterBadPulses_checking'
Full changeset: 7e18fbba4089c5362dedd44713ce26fcfff4101b
Note: See
TracTickets for help on using
tickets.