Ticket #9240 (closed: fixed)
SANS: problem with using add files
Reported by: | Anders Markvardsen | Owned by: | Anders Markvardsen |
---|---|---|---|
Priority: | blocker | Milestone: | Release 3.2 |
Component: | SANS | Keywords: | |
Cc: | peter.parker@…, richard.heenan@… | Blocked By: | |
Blocking: | Tester: | Martyn Gigg |
Description (last modified by Anders Markvardsen) (diff)
Symphom
Files used in example are available from
Olympic\Babylon5\Public\rkh\forAnders
and runs from
isis\inst$\NDXSANS2D\Instrument\data\cycle_13_4
- Open isis sans gui select instrument sans2d and mask file MASKSANS2D_134E_4m_6mm_M4_trans_Dreiss.txt and 'Single run mode'
- Add sample run '22688' and add SANS2D00022689-add.nxs both and sample transmission and direct
- do 1D reduce
In red you should get the log message:
All arguments to init must be positive and non-zero Error in execution of algorithm LoadNexusMonitors: All arguments to init must be positive and non-zero
The reason for this is that LoadNexusMonitors gets executed on histogram workspaces also in python code.
Attachments
Change History
Changed 7 years ago by Anders Markvardsen
- Attachment MASKSANS2D_134E_4m_6mm_M4_trans_Dreiss.txt added
comment:3 Changed 7 years ago by Anders Markvardsen
- Status changed from assigned to inprogress
restrict use of loadnexusmonitor. re #9240
Changeset: b5493d2ae1d5d4d88dd88bdbd82c17ea36d41ab1
comment:4 Changed 7 years ago by Anders Markvardsen
To tester:
Follow the steps in description. If you don't see error message:
All arguments to init must be positive and non-zero Error in execution of algorithm LoadNexusMonitors: All arguments to init must be positive and non-zero
then OK
comment:5 Changed 7 years ago by Anders Markvardsen
- Status changed from inprogress to verify
- Resolution set to fixed
comment:6 Changed 7 years ago by Anders Markvardsen
- Status changed from verify to reopened
- Resolution fixed deleted
comment:7 Changed 7 years ago by Anders Markvardsen
- Status changed from reopened to inprogress
to cover all combinations of event and hist input. re #9240
Changeset: 740a90192e2a1df0bcda6710477386402f03e48f
comment:8 Changed 7 years ago by Anders Markvardsen
forgot to delete a temporary comment in prev com. re #9240
Changeset: 4281a13a374622db09132967b6f2649f6715960a
comment:9 Changed 7 years ago by Anders Markvardsen
To Tester:
In addition to the tests in comment 4, test also that sample='22688', transmission=direct='22689' work and optionally other combinations of run numbers and add-files
check systemtests have passed
comment:12 Changed 7 years ago by Anders Markvardsen
Revert "forgot to delete a temporary comment in prev com. re #9240"
This reverts commit 4281a13a374622db09132967b6f2649f6715960a.
Changeset: 70ffb311e8a0ec5c06c1baf13cad4c0df0b661db
comment:13 Changed 7 years ago by Anders Markvardsen
reverting code back for now. re #9240
Changeset: ff125dfcb8d939de42a251bbcde71e3111cf22e5
comment:14 Changed 7 years ago by Anders Markvardsen
Added additional check to see if workspaces in ADS. re #9240
Changeset: 4d66c4d8d316557b70c036f8a946373a61c87411
comment:15 Changed 7 years ago by Anders Markvardsen
- Status changed from inprogress to verify
- Resolution set to fixed
To test: see comment 9
comment:16 Changed 7 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:17 Changed 7 years ago by Martyn Gigg
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9240_sans_add_files'
Full changeset: 7191a538d065904d589c96641ae6adf491a09cb7
comment:18 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10083