Ticket #9357 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Eliminate managed workspaces

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

Now that support for 32 bit windows is finished, we should get rid of ManagedWorkspace2D and CompressedWorkspace2D and fall back on swap (as we already do for Event workspaces). Some support has been voiced for ManagedRawFileWorkspace but I expect that the changes required are not justified by the (merely perceived) benefit.

I was prompted to write this now as I've been having trouble with a system test (ISISDirectInelastic.LETReductionEvent2014Multirep) that fails if it goes to managed workspaces.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

While I was in previous support of ManagedRawFileWorkspaces, I'm also agreeing that the only usage of this is really for dome purposes rather than real life usage.

Can you also update the ADD if needed, and mark the detailed design document as obsolete.

comment:2 Changed 6 years ago by Russell Taylor

  • Status changed from assigned to inprogress

Re #9357. Remove CompressedWorkspace and all references thereto.

Changeset: 900891bcb1c6ae0d8e861ca7c2c2a4af1b62059b

comment:3 Changed 6 years ago by Russell Taylor

Re #9357. Remove DataObjects depency on zlib.

It was only used by CompressedWorkspace (which is now gone).

Changeset: 59f2b71eec62367bb5683b5c9eabb8cae77fa6d9

comment:4 Changed 6 years ago by Russell Taylor

Re #9357. Remove ManagedRawFileWorkspace2D.

Changeset: 02a18b45f9c738d5e0d26523b17032349b645cc3

comment:5 Changed 6 years ago by Russell Taylor

Re #9357. Remove Managed Workspaces

along with associated classes and references thereto.

Now that we only support 64 bit we can just fall back on swap when memory runs out.

Changeset: c595e7fa242470a3d6b5cfbfa25a51bd6a509d24

comment:6 Changed 6 years ago by Russell Taylor

Merge branch 'feature/9357_eliminate_managedworkspaces' into develop

Conflicts:

Code/Mantid/Framework/DataObjects/test/ManagedHistogram1DTest.h

Re #9357.

Changeset: fcbee207a421b6836fc93b00c3bff0f246df429f

comment:7 Changed 6 years ago by Russell Taylor

Re #9357. Slight refactoring now that managed WS is gone.

The comments indicate that something unusual we being done because of managed workspaces.

Changeset: 208633ab7a21eb10cca711320e9c76eae36122a9

comment:8 Changed 6 years ago by Russell Taylor

Re #9357. Mark Managed Workspace design document as obsolete.

Also updated ADD to state that managed workspaces have been removed.

Changeset: 1997dcb467dee20dffab18821ed146974414fc2e

comment:9 Changed 6 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed

This absence of managed workspaces has been in develop for a couple of weeks now with no apparent ill effects.

To test, make sure that there's no more mention of ManagedWorkspace anywhere in the codebase and see that unit and system tests are all passing.

comment:10 Changed 6 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:11 Changed 6 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9357_eliminate_managedworkspaces'

Full changeset: 2c2a8ca33d8a578eee57768fa315153dfefe4ed6

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10200

Note: See TracTickets for help on using tickets.