Ticket #9358 (closed: fixed)
Make GeneratePeaks more user friendly
| Reported by: | Wenduo Zhou | Owned by: | Wenduo Zhou |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.2 |
| Component: | Framework | Keywords: | |
| Cc: | petersonpf@… | Blocked By: | |
| Blocking: | Tester: | Vickie Lynch |
Description
GeneratePeaks only accepts peak and background parameters from table workspace. It is not convenient for calling it other from the result of FindPeaks. Make its user interface similar to FitPeak such that user can input function parameters as list of double with hint on parameter names.
The column names of output parameter tableworkspace from FindPeaks have been changed after refactoring of FindPeaks. Make it compatible.
Add a new option to plot background only.
Change History
comment:3 Changed 6 years ago by Wenduo Zhou
Added some properties. Refs #9358.
Changeset: 959be2b48364034b5baf62961b5644e9acbd5fed
comment:4 Changed 6 years ago by Wenduo Zhou
Started to refactor the original code. Refs #9358
Changeset: 66c9dcf838e78fa233561463e8cdb3a8254e919a
comment:5 Changed 6 years ago by Wenduo Zhou
Checkpointing work (progress). Refs #9358.
Changeset: 92a33c99742ee9ccde000b1c0ea99b4856837d53
comment:6 Changed 6 years ago by Wenduo Zhou
Refs #9358. Refactor continues.
Changeset: 996bc516743670b16bbecc939ca43adc32462ef0
comment:7 Changed 6 years ago by Wenduo Zhou
Refs #9358. Checkpointing work without compiling error.
Changeset: 58e21d9ebd61769ab1a9c0ab7aa14c1789326dbb
comment:8 Changed 6 years ago by Wenduo Zhou
Refs #9358. Checkpointing work for unit test.
Changeset: e0a33a3aa9dd1f7a6a0004e38433a6319afd3b22
comment:9 Changed 6 years ago by Wenduo Zhou
Corrected an error in function name. Refs #9358.
Changeset: 97085ab06a7542c48a68d8ff82cb38e5e1933aa7
comment:10 Changed 6 years ago by Wenduo Zhou
Fixed error for fx.parname style input. Refs #9358.
Changeset: 0161bf896d4849bdc33ac9c61af36cbef54d489c
comment:11 Changed 6 years ago by Wenduo Zhou
Cleaned the codes. Refs #9358.
Changeset: af37501aeaf7c067567f3165c62226849fcea021
comment:12 Changed 6 years ago by Wenduo Zhou
Refs #9358. Enhancing the usability (in progress).
Including (1) allowing users to input function parameter values as vector; (2) providing hints on parameter names to user
Changeset: 852725052aeee4997b70a2d5116c11ad3f858ce9
comment:13 Changed 6 years ago by Wenduo Zhou
Fixed some errors in unit tests. Refs #9358.
Changeset: fb76197f843569e9280e46cdde5ed3d491f3ba60
comment:14 Changed 6 years ago by Wenduo Zhou
Removed workspaces generated in unit tests. Refs #9358.
Changeset: 84bf2437a07af76227e084eca9042f85d84b59bc
comment:15 Changed 6 years ago by Wenduo Zhou
Refs #9358. Added and fixed unit tests.
Changeset: eed5c15e731fbe09154974917a7e086891a2284d
comment:16 Changed 6 years ago by Wenduo Zhou
Refs #9358. Cleaned up debug output.
Changeset: 046f20af983090eddf1c36ff3ea368f2a48807a8
comment:17 Changed 6 years ago by Wenduo Zhou
Refs #9358. Resolved conflicts.
Changeset: 0976ede48bc1f39467514cba90846b44a2e2c34b
comment:18 Changed 6 years ago by Wenduo Zhou
Refs #9358. Fixed an error during resolving conflicts.
Changeset: fb732f24d9d3c199170c2843c2b71717509b02e2
comment:19 Changed 6 years ago by Wenduo Zhou
Refs #9358. Fixed an error during resolving conflicts.
Changeset: e642a4a30c23a4c1f12b11019559f8889d0895ec
comment:20 Changed 6 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
For tester
The new feature added to GeneratePeaks is to input peak and background parameters in dialog other than table workspace. You can test the new feature by giving the parameters in format of raw parameter values or effective parameter values.
Meanwhile, the old functionality is still kept. You might check the unit tests.
comment:21 Changed 6 years ago by Samuel Jackson
- Status changed from verify to verifying
- Tester set to Samuel Jackson
comment:22 Changed 6 years ago by Samuel Jackson
- Status changed from verifying to reopened
- Resolution fixed deleted
I'm getting a merge conflict when trying to test this. I think it just needs master merged in.
comment:23 Changed 6 years ago by Wenduo Zhou
- Status changed from reopened to inprogress
Added some properties. Refs #9358.
Changeset: b645e514678c5cc63487b67714c11f6083e3913e
comment:24 Changed 6 years ago by Wenduo Zhou
Started to refactor the original code. Refs #9358
Changeset: c062d066681962e427b1c0489a252999fa94b920
comment:25 Changed 6 years ago by Wenduo Zhou
Checkpointing work (progress). Refs #9358.
Changeset: 8d49082de90b5d1a5dcec9d899c07c72bae241c9
comment:26 Changed 6 years ago by Wenduo Zhou
Refs #9358. Refactor continues.
Changeset: 22b52eb7bef05a20e3c465ee35ded68c6f831193
comment:27 Changed 6 years ago by Wenduo Zhou
Refs #9358. Checkpointing work without compiling error.
Changeset: 5d48459293d8e5738ddc1536459ec587ff6915c0
comment:28 Changed 6 years ago by Wenduo Zhou
Refs #9358. Checkpointing work for unit test.
Changeset: 5b4bcd489c9bad34ae6aaa1640e1ce1a928f9356
comment:29 Changed 6 years ago by Wenduo Zhou
Corrected an error in function name. Refs #9358.
Changeset: f538fbc847445590fbd4fdac701ec2679747b4f3
comment:30 Changed 6 years ago by Wenduo Zhou
Fixed error for fx.parname style input. Refs #9358.
Changeset: 567193b2619fa20e7194b0a6bd601ef7b3124200
comment:31 Changed 6 years ago by Wenduo Zhou
Cleaned the codes. Refs #9358.
Changeset: d00f4d3ab5ba62aa5868233519703e55dce605fd
comment:32 Changed 6 years ago by Wenduo Zhou
Refs #9358. Enhancing the usability (in progress).
Including (1) allowing users to input function parameter values as vector; (2) providing hints on parameter names to user
Changeset: 7faf24b40cc13daa45c814f7dcde3abf8a977f06
comment:33 Changed 6 years ago by Wenduo Zhou
Fixed some errors in unit tests. Refs #9358.
Changeset: 74ac942ce67c7790942845b6fee752cbcb0669c6
comment:34 Changed 6 years ago by Wenduo Zhou
Removed workspaces generated in unit tests. Refs #9358.
Changeset: 85598b641222abd3721b7a7f300df623086c7fef
comment:35 Changed 6 years ago by Wenduo Zhou
Refs #9358. Added and fixed unit tests.
Changeset: 7dd4d601eea14e20f7f2eeae8be34e123cc9dcb5
comment:36 Changed 6 years ago by Wenduo Zhou
Refs #9358. Cleaned up debug output.
Changeset: ac573573f8708b4bf0da36cb4d88ff801dfb06ef
comment:37 Changed 6 years ago by Wenduo Zhou
Fixed some error on reading function type. Refs #9358.
Changeset: af7289fa41290b5dab95bfa7a5ecff45a92141a3
comment:38 Changed 6 years ago by Wenduo Zhou
Refs #9358. Merge branch 'feature/9358_gen_peak_enhance.
of github.com:mantidproject/mantid into feature/9358_gen_peak_enhance
Conflicts:
Code/Mantid/Framework/Algorithms/inc/MantidAlgorithms/GeneratePeaks.h Code/Mantid/Framework/Algorithms/src/GeneratePeaks.cpp
Changeset: 9ffa9d06362455a8ae5f88a88e74f1fc44923a4a
comment:39 Changed 6 years ago by Wenduo Zhou
Refs #9358. Resolved conflict.
Changeset: 9076bd90dc84d0929b829d21a8bf3c835079adce
comment:40 Changed 6 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
comment:41 Changed 6 years ago by Vickie Lynch
- Status changed from verify to verifying
- Tester changed from Samuel Jackson to Vickie Lynch
comment:42 Changed 6 years ago by Vickie Lynch
- Status changed from verifying to closed
Merge remote branch 'origin/feature/9358_gen_peak_enhance'
Full changeset: 8893776713f71b6552bebee280e74504d9f8be2f
comment:43 Changed 6 years ago by Wenduo Zhou
Refs #9358. Resolved conflicts.
Changeset: 0976ede48bc1f39467514cba90846b44a2e2c34b
comment:44 Changed 6 years ago by Wenduo Zhou
Refs #9358. Fixed an error during resolving conflicts.
Changeset: fb732f24d9d3c199170c2843c2b71717509b02e2
comment:45 Changed 6 years ago by Wenduo Zhou
Refs #9358. Fixed an error during resolving conflicts.
Changeset: e642a4a30c23a4c1f12b11019559f8889d0895ec
comment:46 Changed 6 years ago by Wenduo Zhou
Refs #9358. Resolved conflict.
Changeset: 9076bd90dc84d0929b829d21a8bf3c835079adce
comment:47 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10201
