Problem With Loading Monitors and Data Separately During Reduction

[Peter Parker]

Within the ISIS SANS reduction we sometimes load data and monitors separately by interrogating the history of the loaded data workspace (SANSUtility.getFilePathFromWorkspace()), finding out which file the data originated from, then going back and loading the monitors from the file.

Unfortunately, our method of interrogating the history is problematic. I have seen the following error message:

Invalid value for property Filename (list of str lists)
"Y:\cycle_13_5\SANS2D00023098.raw":
File "Y:\cycle_13_5\SANS2D00023098.raw" not found

Which stems from the fact that I was using added data files given to me by Richard, which originated from a directory I no longer have access to.

Richard has also seen the following:

CloneWorkspace started
CloneWorkspace successful, Duration 0.28 seconds
RuntimeError: Failed while looking for file in workspace: __CurrentMask
at line 10928 in '<Interface>'
caused by line 1007 in 'C:/MantidInstall/scripts/SANS\ISISCommandInterface.py'
caused by line 455 in 'C:/MantidInstall/scripts/SANS\SANSUtility.py'
caused by line 440 in 'C:/MantidInstall/scripts/SANS\SANSUtility.py'
caused by line 431 in 'C:/MantidInstall/scripts/SANS\SANSUtility.py'

Which may or may not be the exact same problem, but speaks to the fact that loading data and monitors separately like this should be avoided if possible.

[Peter Parker]

Refs #9359 - Stop going back to reload monitors from file.

Unfortunately there is still use for getFilePathFromWorkspace so I've left that in.

Changeset: 9293fbcd270d43e73478070bea615bf4e90a3f5c

[Peter Parker]

To Test (ISIS Only)

It might be helpful to make sure you can reproduce the error:

• Take the following files from \\isis\inst$\Instruments$\NDXSANS2D\user\Masks and store them in a local folder managed by Mantid:
  • MASKSANS2D_141D_4m_Edler_M3_8mm_TwoDets.txt - (User File)
  • TubeCalibrationTable_512pixel_24Mar14.nxs
  • DIRECT_23067_4m_Rear_22Mar14.dat

• Start up ISIS SANS interface and load the user file you copied in the previous step.

• Load some new gas-tube SANS2D data from the archive. Run 23548 is as good as any.

• On the Masking tab click "Display Mask".

You should be seeing this error:

RuntimeError: Failed while looking for file in workspace: __CurrentMask

Do the same thing after you've merged the changes, and you should no longer get the error.

[Anders Markvardsen]

Merge remote-tracking branch 'origin/bugfix/9359_stop_loading_monitors_separately'

Full changeset: ​9c1a438f70d1bf24378b30d51cdea9567af3716b

[Anders Markvardsen]

Loaded mask etc direct from
isis\inst$ . Checked that line ntimeError: Failed while looking for file in workspace: CurrentMask was output in result log.

The last part of result log was:

Minus successful, Duration 1.06 seconds Unlocking CurrentMask Unlocking DisplayMasked_tempory_wksp Unlocking units DeleteWorkspace started Algorithm: DeleteWorkspace v1 Parameters:

Name: Workspace, Value: ones, Default?: No, Direction: Input

Read-locking ones Data Object 'ones' deleted from data service. DeleteWorkspace successful, Duration 0.00 seconds Unlocking DeleteWorkspace started Algorithm: DeleteWorkspace v1 Parameters:

Name: Workspace, Value: units, Default?: No, Direction: Input

Read-locking units Data Object 'units' deleted from data service. DeleteWorkspace successful, Duration 0.00 seconds Unlocking DeleteWorkspace started Algorithm: DeleteWorkspace v1 Parameters:

Name: Workspace, Value: DisplayMasked_tempory_wksp, Default?: No, Direction: Input

Read-locking DisplayMasked_tempory_wksp Data Object 'DisplayMasked_tempory_wksp' deleted from data service. DeleteWorkspace successful, Duration 0.00 seconds Unlocking

[Stuart Campbell]

This ticket has been transferred to github issue ​10202