Ticket #9367 (assigned)

Opened 6 years ago

Last modified 5 years ago

Don't Load Any IDFs Until We Know Which Version of the Instrument Should Be Used

Reported by: Peter Parker Owned by: Peter Parker
Priority: critical Milestone: Backlog
Component: SANS Keywords:
Cc: anders.markvardsen@… Blocked By:
Blocking: Tester:


The ISIS SANS system tests currently load IDF's without knowing which version of the instrument the data being reduced corresponds to. LOQ has for some reason been hard-coded to use the second-to-last (chronologically speaking) of the four available IDF's by default, and since #9361, SANS2D defaults to the *oldest* of two IDF's.

To further complicate matters, the ISIS SANS interface actually waits until some data has been loaded before reading IDFs (and so is able to pick the correct one), except in the case where users go straight to the Masking tab and click "Display Mask" without first loading data. In that case, the defaults mentioned above are also used.

This is a mess.

My preference here would be to get rid of these arbitrary defaults and instead simply enforce a universal rule that no IDF-dependant ISIS SANS command can take place without first knowing which data file (and therefore which exact IDF) is being used. This would be the cleanest (and I'd also argue, easiest) way to guarantee that the correct IDF is being used at any given time.

I need to run this by the scientists, but I think they will be in general agreement.

Change History

comment:1 Changed 6 years ago by Peter Parker

  • Cc anders.markvardsen@… added

comment:2 Changed 6 years ago by Peter Parker

  • Blocking 8308 added

comment:3 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:4 Changed 6 years ago by Peter Parker

Note to self:

We have the following line in lot's of our system tests


This is likely because we're using slightly different instruments at various parts in the reduction (the hard-coded or default IDF at the beginning, the one loaded with the data by the end). I'm pretty sure that by the end of this ticket we'll be able to remove this.

Last edited 6 years ago by Peter Parker (previous) (diff)

comment:5 Changed 6 years ago by Peter Parker

  • Milestone changed from Release 3.2 to Backlog

comment:6 Changed 5 years ago by Peter Parker

  • Blocking 8308 removed

(In #8308) See updated ticket description, and ignore previous comment from Gesner.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10210

Note: See TracTickets for help on using tickets.