Ticket #9377 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Correct T0 in SaveIsawPeaks

Reported by: Vickie Lynch Owned by: Vickie Lynch
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

The T0 is always 0 even when using DetCal file has nonzero value. Check in SaveIsawPeaks and LoadIsawPeaks.

Attachments

TOPAZ_27Aug2013.DetCal​ (2.2 KB) - added by Vickie Lynch 6 years ago.

Change History

comment:1 Changed 6 years ago by Owen Arnold

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Vickie Lynch

  • Status changed from assigned to inprogress

Refs #9377 save T0 for output; output all banks in peaks file

Changeset: fa477742145cf4e94256c11d36118f80dd51fc3a

comment:3 Changed 6 years ago by Vickie Lynch

Uploaded DetCal file has exagerated T0 so plots of spectra of TOPAZ_3132_event and TOPAZ_3132_event_orig have visible T0 change. Look for T0=147 in output, new.DetCal and topaz.peaks. Also topaz.peaks now has bank 48 in header even though there are no peaks from bank 48. 

Load(Filename=r'TOPAZ_3132_event.nxs',OutputWorkspace='TOPAZ_3132_event')
Rebin(InputWorkspace='TOPAZ_3132_event',OutputWorkspace='TOPAZ_3132_event_orig',Params='-0.01')
SaveIsawDetCal(InputWorkspace='TOPAZ_3132_event',Filename='old.DetCal')
LoadIsawDetCal(InputWorkspace='TOPAZ_3132_event',Filename=r'TOPAZ_27Aug2013.DetCal')
Rebin(InputWorkspace='TOPAZ_3132_event',OutputWorkspace='TOPAZ_3132_event',Params='-0.01')
SaveIsawDetCal(InputWorkspace='TOPAZ_3132_event',Filename='new.DetCal')
ConvertToMD(InputWorkspace='TOPAZ_3132_event',QDimensions='Q3D',dEAnalysisMode='Elastic',Q3DFrames='Q_sample',LorentzCorrection='1',OutputWorkspace='TOPAZ_3132_md',MinValues='-25,-25,-25',MaxValues='25,25,25',SplitInto='2',SplitThreshold='50',MaxRecursionDepth='13',MinRecursionDepth='7')
FindPeaksMD(InputWorkspace='TOPAZ_3132_md',PeakDistanceThreshold='0.37680000000000002',MaxPeaks='50',DensityThresholdFactor='100',OutputWorkspace='TOPAZ_3132_peaks')
SaveIsawPeaks(InputWorkspace='TOPAZ_3132_peaks',Filename='topaz.peaks')

Changed 6 years ago by Vickie Lynch

comment:4 Changed 6 years ago by Vickie Lynch

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:5 Changed 6 years ago by Vickie Lynch

  • Status changed from verify to reopened
  • Resolution fixed deleted

Cppcheck error

comment:6 Changed 6 years ago by Vickie Lynch

  • Status changed from reopened to inprogress

Refs #9377 remove suppression

Changeset: 3233be46921557940d970542e093c09d945b39f3

comment:7 Changed 6 years ago by Vickie Lynch

Refs #9377 supression for correct line

Changeset: 1c6fd2518fc31af470b0f6f9b5644aac08b7e4d8

comment:8 Changed 6 years ago by Vickie Lynch

  • Status changed from inprogress to verify
  • Resolution set to fixed

cppcheck error fixed

comment:9 Changed 6 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:10 Changed 6 years ago by Wenduo Zhou

  • Status changed from verifying to reopened
  • Resolution fixed deleted

comment:11 Changed 6 years ago by Russell Taylor

This commit ​https://github.com/mantidproject/mantid/commit/fa477742145cf4e94256c11d36118f80dd51fc3a has led to the OptimizeLatticeForCellTypeTest unit test taking way too long - minutes in some cases. The test will need to be sped up dramatically before this work is merged.

comment:12 Changed 6 years ago by Vickie Lynch

  • Status changed from reopened to inprogress

Refs #9377 use bank names from peaks

Changeset: 8f8fe1a67a2b17363bd85b0e498bf3a0aa6156eb

comment:13 Changed 6 years ago by Vickie Lynch

  • Status changed from inprogress to verify
  • Resolution set to fixed

Closed again without the slow instrument searches for bank names. See testing suggestions near beginning of ticket.

comment:14 Changed 6 years ago by Russell Taylor

The branch for this needs to be merged into develop again before this is tested (develop was reset to match master at some point).

comment:15 Changed 6 years ago by Vickie Lynch

Just merged into develop

comment:16 Changed 6 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester changed from Wenduo Zhou to Andrei Savici

comment:17 Changed 6 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9377_T0_in_DetCal'

Full changeset: ​f79d377e85f11423640447d3b8cd4a4e667074a7

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10220

Note: See TracTickets for help on using tickets.