Ticket #9394 (closed: fixed)
Loader for BILBY beamline at ANSTO
Reported by: | Anders Markvardsen | Owned by: | Anders Markvardsen |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.2 |
Component: | SANS | Keywords: | |
Cc: | peter.parker@…, davidm@… | Blocked By: | |
Blocking: | Tester: | Karl Palmen |
Description
Ticket to be a placeholder for pull request (https://github.com/mantidproject/mantid/blob/master/CONTRIBUTING.md) to add this loader
Change History
comment:1 Changed 6 years ago by Nick Draper
- Status changed from new to assigned
- Milestone changed from Backlog to Release 3.2
comment:4 Changed 6 years ago by Anders Markvardsen
- Status changed from assigned to inprogress
Adding David Mannicke's Bilby loader. re #9394
add a small dataset David provided
Changeset: d73925809f7807d56c37b04aafdde7c5af43ee32
comment:5 Changed 6 years ago by Anders Markvardsen
Modified cmake to include loadbby. re #9394
and modified loadbby to use new summary() method instead of now old SetWikiSummary and SetOptionalText methods, see http://www.mantidproject.org/Algorithm_Documentation#The_Summary_method
Changeset: 16f6a8350fc66f197fc8f8d1ec1a3aa48bedfe0c
comment:6 Changed 6 years ago by Anders Markvardsen
add rst file for bilby. re #9394
Changeset: 7798814da01d6d5c6b1103dc7f7bacbde58a3419
comment:7 Changed 6 years ago by Anders Markvardsen
Fix to build. Remove cross platform calls. re #9394
Changeset: 626b84e5cde719834628733401a9096cc7593264
comment:8 Changed 6 years ago by Anders Markvardsen
Revert "Modified cmake to include loadbby. re #9394"
This reverts commit 16f6a8350fc66f197fc8f8d1ec1a3aa48bedfe0c.
temp uncommit changes
Changeset: 48f7272453f15f3e916c3e25afdd60e4a65f1d93
comment:9 Changed 6 years ago by Anders Markvardsen
Revert "Revert "Modified cmake to include loadbby. re #9394""
This reverts commit 48f7272453f15f3e916c3e25afdd60e4a65f1d93.
Changeset: 78ac37315f09d579ea3aa1c45c36a3e1b5ae87c3
comment:10 Changed 6 years ago by Anders Markvardsen
fixes to mac build. re #9394
note emplace_back not supported on a mac compiler
Changeset: b7800461316945085b00c82bb38945c7e9966d6d
comment:11 Changed 6 years ago by Anders Markvardsen
remove cppcheck warnings. re #9394
remove new added at http://builds.mantidproject.org/job/cppcheck_develop/759/
Changeset: 172575f3b06b8aaf03104230c1a7e75eff05b83b
comment:12 Changed 6 years ago by Anders Markvardsen
Added loadbby unit test. re #9394
And renamed property "Hdf Reference" to "HdfReference" to satisfy http://builds.mantidproject.org/job/develop_systemtests_rhel6/lastCompletedBuild/testReport/SystemTests/CodeConventions/Algorithms/ (tx to martyn for spotting this)
Changeset: 8f8a1eb0db8c566d51f35916aba611506f438b61
comment:13 Changed 6 years ago by Anders Markvardsen
- Status changed from inprogress to verify
- Resolution set to fixed
To test:
- In mantidplot load Bilby_EOS.bin in AutoTestdata and check that a workspace is created
- check unit loadbby unit test is passing
comment:14 Changed 6 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:15 Changed 6 years ago by Karl Palmen
Code review reveals that loadBBY has not yet got a usage example in the documentation. I expect this is covered by another ticket. Please create one if this is not thes case.
comment:16 Changed 6 years ago by Karl Palmen
- Status changed from verifying to reopened
- Resolution fixed deleted
Bilby_EOS.bin not found in AutoTestData.
comment:17 Changed 6 years ago by Anders Markvardsen
- Status changed from reopened to verify
- Resolution set to fixed
According to https://github.com/mantidproject/mantid/tree/feature/9394_loader_bilby_/Test/AutoTestData
the dataset should be there. Note the branch name is feature/9394_loader_bilby_ i.e. ending with a "_"
To test: see comment 13
comment:19 Changed 6 years ago by Karl Palmen
I found that the Bilby_EOS.bin is present in the folder, but does not by default appear in the dialog box of Load, because it (*.bin) is not classed as a data file. Selecting 'All File (*.*)' makes it appear.
comment:20 Changed 6 years ago by Karl Palmen
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9394_loader_bilby_'
Full changeset: cbf47f05dd3398b9a69a88551cf399e4e4bc4e41
comment:21 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10237
moved to R3.2 due to ANSTO deadlines