Ticket #9395 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Empty ISIS indirect inelastic system test methods

Reported by: Jay Rainey Owned by: Samuel Jackson
Priority: minor Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Parker

Description

When code reviewing #8284 I noticed that there are several empty method bodies for _validate_properties in the ​ISIS indirect inelastic system test.

Change History

comment:1 Changed 6 years ago by Owen Arnold

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Samuel Jackson

  • Status changed from assigned to inprogress

Refs #9395 Add unimplemented methods to system tests.

Changeset: 76b8b2eda9796e3a4197a653d3867e28f2354b03

comment:3 Changed 6 years ago by Samuel Jackson

Refs #9395 General tidying & PEP8 warnings.

Changeset: a618ef731bb98041129a83f0e794c6a75c0a9906

comment:4 Changed 6 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:5 Changed 6 years ago by Samuel Jackson

To Test

Check the system tests are passing and do a code review.

comment:6 Changed 6 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

Sam, this one needs to be "published".

comment:7 Changed 6 years ago by Samuel Jackson

Sorry. Should be published now.

comment:8 Changed 6 years ago by Peter Parker

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9395_indirect_empty_validate_methods'

Full changeset: ​f83910854c50f668ebed3b30b383e8436c33fa12

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10238

Note: See TracTickets for help on using tickets.