Ticket #9396 (closed: fixed)
Rename ConvertToMDHelper and ConvertToMDHelper2 propertly
Reported by: | Alex Buts | Owned by: | Alex Buts |
---|---|---|---|
Priority: | trivial | Milestone: | Release 3.2 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #8026 | Tester: | Samuel Jackson |
Description
According to the conversation happened a month ago, nobody objects agains renaming these algorithms into ConvertToMDMinMaxGlobal and ConvertToMDMinMaxLocal.
This is trivial job. All other suggestions made that time are less trivial, so I am postponing them until discussed more thoroughly.
Change History
comment:2 Changed 6 years ago by Alex Buts
- Status changed from assigned to inprogress
refs #9396 Renamed unit tests for these algorithms.
Changeset: b0bdf17d29587bcac30ee59a7d7ed9313a96e288
comment:3 Changed 6 years ago by Alex Buts
refs #9396 ConvertToMDMinMaxLocal correct version
Changeset: 2f519b07418870a195bf58fbcdcc1c23cc389fcf
comment:4 Changed 6 years ago by Alex Buts
refs #9396 Comments and one more test using old name
Changeset: 9474a36a9bc8c90b2cd898333b33f2eff40773f7
comment:5 Changed 6 years ago by Alex Buts
- Status changed from inprogress to verify
- Resolution set to fixed
- Blocking 8026 added
This ticket renames algorithms without changes in functionality.
It is easy to test as changes are trivial.
Changes are both in Mantid and system test branch as one system test was excluding previous algorithm names and so the new names should also be excluded.
comment:6 Changed 6 years ago by Alex Buts
refs #9396 System test complain fixed
Changeset: e07ebe6dc9b5ee5e475945eef764b52eaeef2e00
comment:9 Changed 6 years ago by Samuel Jackson
- Status changed from verify to verifying
- Tester set to Samuel Jackson
comment:10 Changed 6 years ago by Samuel Jackson
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9396_ConvertToMDHelpersNames'
Full changeset: ade8b4aa89482f4e64f102b8e054224113dedb45
comment:11 Changed 6 years ago by Samuel Jackson
Merge remote-tracking branch 'origin/feature/9396_ConvertToMDHelpersNames'
Full changeset: dc9dedec8c0289ba564423d2487b8c2ed7b5fa1c
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10239