Context Navigation

Ticket #9413 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

AnvredCorrection needs more corrections

Reported by:	Vickie Lynch	Owned by:	Vickie Lynch
Priority:	major	Milestone:	Release 3.2
Component:	Framework	Keywords:
Cc:		Blocked By:
Blocking:	#9411	Tester:	Michael Reuter

Description

For TOPAZ add corrections for detector bank scaling and slant path through the scintillator glass that are in SaveHKL.

Change History

comment:1 Changed 6 years ago by Vickie Lynch

Blocking 9411 added

comment:2 Changed 6 years ago by Vickie Lynch

Status changed from new to assigned

comment:3 Changed 6 years ago by Vickie Lynch

Status changed from assigned to inprogress

Refs #9413 add more corrections

Changeset: d50020fdc7a04335f58de8cfa37894e202a46c04

comment:4 Changed 6 years ago by Vickie Lynch

To test:

Load(Filename='TOPAZ_3132_event.nxs',OutputWorkspace='TOPAZ_3132_event')
LoadIsawUB(InputWorkspace='TOPAZ_3132_event',Filename='TOPAZ_3007.mat')
SetSampleMaterial(InputWorkspace='TOPAZ_3132_event',ChemicalFormula='LiFePO4',ZParameter='4')
AnvredCorrection(InputWorkspace='TOPAZ_3132_event',OutputWorkspace='event_scale',Radius='0.10000000000000001',DetectorBankScaleFactors='1')
AnvredCorrection(InputWorkspace='TOPAZ_3132_event',OutputWorkspace='event_noscale',Radius='0.10000000000000001')
Rebin(InputWorkspace='TOPAZ_3132_event',OutputWorkspace='TOPAZ_3132_histo',Params='-0.01',PreserveEvents='0')
Rebin(InputWorkspace='event_scale',OutputWorkspace='event_scale',Params='-0.01',PreserveEvents='0')
Rebin(InputWorkspace='event_noscale',OutputWorkspace='event_noscale',Params='-0.01',PreserveEvents='0')
AnvredCorrection(InputWorkspace='TOPAZ_3132_histo',OutputWorkspace='histo_scale',Radius='0.10000000000000001',DetectorBankScaleFactors='1')
AnvredCorrection(InputWorkspace='TOPAZ_3132_histo',OutputWorkspace='histo_noscale',Radius='0.10000000000000001')

comment:5 Changed 6 years ago by Vickie Lynch

Status changed from inprogress to verify
Resolution set to fixed

comment:6 Changed 6 years ago by Nick Draper

Milestone changed from Backlog to Release 3.2

comment:7 Changed 6 years ago by Michael Reuter

Status changed from verify to verifying
Tester set to Michael Reuter

comment:8 Changed 6 years ago by Michael Reuter

Status changed from verifying to reopened
Resolution fixed deleted

There is a lot of duplicated code here. It looks like things could be consolidated to single function calls that are then used in the exec() and execEvent() calls. This makes future modification less prone to error. This suggestion is predicated on the fact that the functions do not change between histogram and event handling which it looks like they don't.