Ticket #9437 (closed: fixed)
Improve Icons Shown in Algorithm Dialogs
Reported by: | Peter Parker | Owned by: | Peter Parker |
---|---|---|---|
Priority: | major | Milestone: | Release 3.2 |
Component: | GUI | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #9372 | Tester: | Nick Draper |
Description
Some feedback from Nick, suggesting some changes to the features introduced by #2480:
- Change the "Restored" icon to be something that denotes "history" a little better. A clock, or similar.
- Have the new history icon be clickable, so that a user may toggle whether or not they'd like to use the value they entered last time. "Striking through" the icon seems sensible in this case.
- Change the "Replace" icon to be a "!" warning sign. Hopefully this makes things a little clearer. This won't be clickable.
- Change the red asterisk to something that matches the size of the other icons.
Change History
comment:2 Changed 6 years ago by Peter Parker
- Status changed from assigned to inprogress
Refs #9437 - Change icons and their behaviour.
Changeset: 311d4b41876e8abbf9a44ec00076d2c77a9ba19c
comment:3 Changed 6 years ago by Peter Parker
- Status changed from inprogress to verify
- Resolution set to fixed
To test, make sure the four changes proposed in the description have been implemented. When testing the history toggle, please make sure you test Bool, Option, Text and File PropertyWidgets, since the code for dealing with history in each case is slightly different. A nice algorithm to use here is CalibrateRectangularDetectors, which has a lot of properties.
Note that the scope of this ticket is the same as #2480, i.e. #9149 exists to spread the property widgets to all the other custom dialogs (i.e. LoadAscii, CatalogPublish, etc).
Also note that #9356 exists to fix a width problem with some of the alg dialogs with larger property names.
comment:5 Changed 6 years ago by Peter Parker
Refs #9437 - fix unused var warning.
Changeset: efcd589a0b1a72ef353f9896d94baff4db073acb
comment:6 Changed 6 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:7 Changed 6 years ago by Nick Draper
I really like the click to ignore / return historic values
comment:8 Changed 6 years ago by Nick Draper
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9437_improve_alg_diag_icons'
Full changeset: 22b319f46e41aab263c5480d32a6b1f076e8b618