Ticket #9438 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Bring recent LET_Description.xml and LET_Parameters.xml to Mantid

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description

LET got couple of additional doors during this cycle and the related changes have been reflected in LET_Definition and LET_Parameters files.

This changes should become available in Mantid distributives.

Change History

comment:1 Changed 6 years ago by Alex Buts

refs #9438 Current state of LET instrument folder.

Redundancies are present and some regularization is necessary.

Changeset: a68637e1509b884b8c46de20fb377540ec60c02f

comment:2 Changed 6 years ago by Alex Buts

refs #9438 Better diagnostics

During IDF changes, it was found difficult to understand what is going wrong when monitor number is specified incorrectly. This change should help to address similar problem in a future.

Changeset: 6dd01e778ad03b27a4efaef927502be00f98a7fc

comment:3 Changed 6 years ago by Alex Buts

refs #9438 Should fix duplicated IDF issue.

Changeset: 2deac857727f9d24f49f332272acaec7b661223a

comment:4 Changed 6 years ago by Alex Buts

refs #9438 Found old dr2to& parameters file smuggled from LET

Changeset: f8c8db966458a738607c7e2b1a7369dca51439bf

comment:5 Changed 6 years ago by Alex Buts

refs #9438 returning missing changes

which were lost from copying IDF and parameter files from mantid 3.0

Changeset: 6d671a4b8ee6c64c8e3d4a83c0744c8aa029b921

comment:6 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:7 Changed 6 years ago by Alex Buts

  • Status changed from assigned to inprogress

refs #9438 fixing system test: Renamed LET_Definition_dr2to7

to LET_Definition

and LET_Parameters accordingly, as LET2014Multirep nexus system tests source files contains old LET_Definition and LET_Parameters, which do not work with recent reduction. The only way to run these files is to reload LET_Definition.xml and LET_Parameters.xml from the IDF.

Changeset: 56bbc36c4338314a11fe3de235a51c966aa84157

comment:8 Changed 6 years ago by Alex Buts

  • Status changed from inprogress to verify
  • Resolution set to fixed

this is simple ticket which brings IS made changes from LET to core Mantid. There are various issues around IDF versioning which are addressed by various different tickets. Because of these issues the IDF names can not be random for system tests to pass. Otherwise, the changes made for this ticket are pretty simple.

The only thing done here except IDF editing is small changes to reduction script which report failed monitor number. (if one indeed fails)

Test by code/changes review on GIT. Changes are small and simple

comment:9 Changed 6 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:10 Changed 6 years ago by Karl Palmen

All three LET definition files OK and show a sensible instrument.

comment:11 Changed 6 years ago by Alex Buts

refs #9438 Current state of LET instrument folder.

Redundancies are present and some regularization is necessary.

Changeset: 784ee6626718a28b612c43633dade68ac82f018d

comment:12 Changed 6 years ago by Alex Buts

refs #9438 Better diagnostics

During IDF changes, it was found difficult to understand what is going wrong when monitor number is specified incorrectly. This change should help to address similar problem in a future.

Changeset: 90f54b53a3bcc8c08b119e0724d4b5945e3e9c1f

comment:13 Changed 6 years ago by Alex Buts

refs #9438 Should fix duplicated IDF issue.

Changeset: b8e16103126e00b3926d44f8a68838891ea0e632

comment:14 Changed 6 years ago by Alex Buts

refs #9438 Found old dr2to& parameters file smuggled from LET

Changeset: dc6e0d80072e9383398e29d5646cca78d7132968

comment:15 Changed 6 years ago by Alex Buts

refs #9438 returning missing changes

which were lost from copying IDF and parameter files from mantid 3.0

Changeset: 355f3a3b5ee0c987f6a4a8a7e0b40a59c0c0c861

comment:16 Changed 6 years ago by Alex Buts

refs #9438 fixing system test: Renamed LET_Definition_dr2to7

to LET_Definition

and LET_Parameters accordingly, as LET2014Multirep nexus system tests source files contains old LET_Definition and LET_Parameters, which do not work with recent reduction. The only way to run these files is to reload LET_Definition.xml and LET_Parameters.xml from the IDF.

Changeset: a4636d88071edd8450152757ad2397f29be445f0

comment:17 Changed 6 years ago by Karl Palmen

  • Status changed from verifying to closed

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10281

Note: See TracTickets for help on using tickets.