Ticket #9440 (closed: fixed)
Stitch1DMany Bug Report
Reported by: | Owen Arnold | Owned by: | Owen Arnold |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.2 |
Component: | Reflectometry | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #9524 | Tester: | Keith Brown |
Description
Attached are two files 1) a pdf and 2) ipython notebook used to create the pdf. The scripts used are the ones I've forwarded to you previously. I've observed some issues with Stitch1DMany. 1) I only get one scale factor from the output. 2) When comparing with the genie stitch, Stitch1DMany mis-calculates or mis-applies a scale factor which results in and offset in intensity for data which should be similar. The results from Stitch1DMany are on page 5 of the PDF and the genie results are shown on page 6. On a side note it would be nice if the function to identify the name and number of returned values from a python function was exposed to us. Currently I've copied in this set of function from else where which may not be the best approach. -Tim
Attachments
Change History
comment:3 Changed 6 years ago by Owen Arnold
refs #9440. Multiple scale factor outputs.
Stitch1DMany adapted to give the scale factors for each Stitch1D step.
Changeset: 1134350a0464b764727b6bbff34aed493318640c
comment:4 Changed 6 years ago by Owen Arnold
refs #9440. Update algorithm documentation.
Changeset: 1d05341cebd63c0ced21f52403d38172cf8347bd
comment:5 Changed 6 years ago by Owen Arnold
I emailed the following python script to Tim to show how information about the inputs of an algorithm could be dynamically fetched:
import mantid.api alg =AlgorithmManager.createUnmanaged("Stitch1D") alg.initialize() properties = alg.getProperties() for prop in properties: print prop.name, " Input" if prop.direction==0 else" Output"
comment:7 Changed 6 years ago by Owen Arnold
Tester
1) Stitch1DMany has been adapted to return all calculated scale factors. Unit tests have been updated to reflect this.
2) Tim has been contacted about how to get algorithm property information
3) ticket #9549 has been opened to determine any possible issues with scale factors in Stitch1D
comment:8 Changed 6 years ago by Owen Arnold
- Status changed from inprogress to verify
- Resolution set to fixed
comment:10 Changed 6 years ago by Owen Arnold
refs #9440. Remove deprecated alg method usage.
Changeset: 159341a524b627a1683c2d98909adef0c7e86e60
comment:11 Changed 6 years ago by Owen Arnold
refs #9440. Merge in master.
Merge branch 'master' into feature/9440_stitch1d_many
Conflicts:
Code/Mantid/Framework/PythonInterface/plugins/algorithms/Stitch1DMany.py
Changeset: 820e7efa38d6f9c67fcf9c660beb1216cf235aed
comment:12 Changed 6 years ago by Keith Brown
- Status changed from verify to verifying
- Tester set to Keith Brown
comment:13 Changed 6 years ago by Keith Brown
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9440_stitch1d_many'
Full changeset: d89eba083f7478f98da29449e4e0cd755e07ba84
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10283