Ticket #9524 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

StichingError

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: critical Milestone: Release 3.2
Component: Reflectometry Keywords:
Cc: Blocked By: #9440, #9475
Blocking: Tester: Michael Reuter

Description

Error reported by Tim Charlton.

For one of the spin states, running Stitch1DMany results in magnification of error bars for one of the stitched workspaces. The steps below are the minimum to reproduce the reported issue. Screen shot attached.

Load(Filename=r'/Users/spu92482/Desktop/Stitching-errors/nIp_DataOut_RcorrectedVsQz_r1q_rr1.nxs',OutputWorkspace='nIp_DataOut_RcorrectedVsQz_r1q_rr1')
Load(Filename=r'/Users/spu92482/Desktop/Stitching-errors/nIp_DataOut_RcorrectedVsQz_r2q_rr2.nxs',OutputWorkspace='nIp_DataOut_RcorrectedVsQz_r2q_rr2')
Load(Filename=r'/Users/spu92482/Desktop/Stitching-errors/nIp_DataOut_RcorrectedVsQz_r3q_rr3.nxs',OutputWorkspace='nIp_DataOut_RcorrectedVsQz_r3q_rr3')

Stitch1DMany(InputWorkspaces='nIp_DataOut_RcorrectedVsQz_r1q_rr1, nIp_DataOut_RcorrectedVsQz_r2q_rr2 ,nIp_DataOut_RcorrectedVsQz_r3q_rr3',OutputWorkspace='stitchednpl',Params='-0.02')

graph_spec = plotSpectrum('stitchednpl',0, error_bars=True)
l = graph_spec.activeLayer()
l.setAxisScale(Layer.Left, 1e-8, 1, Layer.Log10)

Attachments

Screen Shot 2014-05-23 at 08.30.50.png (21.0 KB) - added by Owen Arnold 6 years ago.

Change History

Changed 6 years ago by Owen Arnold

comment:1 Changed 6 years ago by Owen Arnold

  • Owner set to Owen Arnold
  • Status changed from new to assigned

comment:2 Changed 6 years ago by Owen Arnold

Error reproduced on version 20th May 2014

comment:3 Changed 6 years ago by Owen Arnold

I can actually reproduce this issue via stitch1D directly by stitching rr2 and rr3 together. So the real problem is not in Stitch1DMany, it is in Stitch1D or something lower.

comment:4 Changed 6 years ago by Owen Arnold

Following some investigation. This was found to be down to some very large error values in the most RHS workspace. In the integration step, errors are squared and sum across all bins. Therefore the ratio multiplication factor ws, had a huge error value that was scaling all the error bars on the corrected, scaled output workspace.

Changing the StartOverlap region as follows fixed the issue as it cuts out the overlap regions where errors are very high.

Stitch1DMany(InputWorkspaces='nIp_DataOut_RcorrectedVsQz_r1q_rr1, nIp_DataOut_RcorrectedVsQz_r2q_rr2 ,nIp_DataOut_RcorrectedVsQz_r3q_rr3',StartOverlaps=[0.0208,0.0208], EndOverlaps=[0.05,0.05],OutputWorkspace='stitchednpl',Params='-0.02')

What Tim has now asked for is to have the error scale factor output from Stitch1D and Stitch1DMany. This would allow the end-user to spot this problem.

comment:5 Changed 6 years ago by Owen Arnold

  • Status changed from assigned to inprogress

comment:6 Changed 6 years ago by Owen Arnold

  • Blocked By 9440 added

comment:7 Changed 6 years ago by Owen Arnold

  • Blocked By 9475 added

comment:8 Changed 6 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment 4 outlines the real problem, and this has been accepted by the user. There are no code changes.

comment:9 Changed 6 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:10 Changed 6 years ago by Michael Reuter

  • Status changed from verifying to closed

Sounds fine to me.

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10367

Note: See TracTickets for help on using tickets.