Ticket #9475 (closed: fixed)
Stitch1D as C++ Algorithm
Reported by: | Owen Arnold | Owned by: | Keith Brown |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.2 |
Component: | Reflectometry | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #9500, #9524 | Tester: | Owen Arnold |
Description
Make Stitch1D a C++ algorithm because it's getting really hard to debug these mixed environments, and technically we shouldn't have child algorithms that are python (called from C++) because the python API isn't a mandatory aspect of the framework. Aside from that, we should then also be see some speed improvements over the python version.
Change History
comment:2 Changed 6 years ago by Owen Arnold
- Status changed from assigned to inprogress
refs #9475. Skeleton algorithm.
Changeset: cca7fd04725649a525dac28a6ebbab1d56c538d8
comment:3 Changed 6 years ago by Owen Arnold
refs #9475. Stop and hand over
I have deliberately left one failing unit test.
Changeset: f2dacd6ed3e9aa70bb5cfb33b18b6f487416b582
comment:6 Changed 6 years ago by Keith Brown
Refs #9475 More tests working, intersect bugfix
Fixed bug in x-intersect code
Got two more tests working and passing
Quashed a few warnings relating to double and unsigned int64 types
Changeset: 294f9fc9293f12ccb827a057f0d4b8f43bed673c
comment:7 Changed 6 years ago by Keith Brown
Refs #9475 Auto-format function over code
Just ran the VS2010 auto formatter over the code to indent things more consistantly
Changeset: 58cb8d268dce9b208ad7f78694015e65bdef250f
comment:8 Changed 6 years ago by Keith Brown
Refs #9475 Fixed some copy-paste errors
There was an error in an output message, and an error in retrieving Y-values from the wrong workspace. Both seemed to be copy-paste errors, both easily fixed as all it ammounted to was 3 characters being changed.
Changeset: 394ffbea07d14872a79aeedb0c1f567c0a46b9ec
comment:9 Changed 6 years ago by Keith Brown
Refs #9475 stiching tests
added 4 of the stitching tests: test_stitching_forces_start_overlap, test_stitching_forces_end_overlap, test_stitching_scale_right and test_stitching_scale_left
Changeset: 396f2eda0bde7243061fd40f83f49d8b2a06dbae
comment:10 Changed 6 years ago by Keith Brown
Refs #9475 Manual Scale Factor and related tests
Manual scale factor override is now implemented
Tests have been ported
Changeset: 080e6553f9619a0406a2fa114e939c8582cc8996
comment:11 Changed 6 years ago by Keith Brown
Refs #9475 Fixing system and unit tests
Fixed a problem in the Stitch1DMany unit test where it wasn't converitng a double to a string
Stitch1D now tkaes range tollerences into account
Changeset: 8d8fb4ae4ce1aeea9e9085a17bd993986646016c
comment:12 Changed 6 years ago by Keith Brown
Refs #9475 Docs and restructuring
Documentation has been added.
The algorithm identification methods have all been moved to the header to save space and the docstrings methods have been changed to the new summary method
Changeset: cef727ece4be12914ba29e5837ebc296ca6a1072
comment:13 Changed 6 years ago by Keith Brown
refs #9475 Fixing build problems
Looks like the buildservers didn't like me plugging boost::assign::list_of straight into a function. I've moved all calls to it to a separate line assigning to a new variable in each instance
Changeset: 3ac2158150e8621ba519404a80a6d2a0f194cfaf
comment:15 Changed 6 years ago by Keith Brown
- Status changed from inprogress to verify
- Resolution set to fixed
comment:16 Changed 6 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:17 Changed 6 years ago by Owen Arnold
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9475_stich1d_cplusplus'
Full changeset: b769a6764ad948a8be1a1b69e5de5b02839a9415
comment:18 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10318