Ticket #9500 (closed: fixed)
CreateTransmissionWorkspaceAuto convert to C++
Reported by: | Keith Brown | Owned by: | Keith Brown |
---|---|---|---|
Priority: | major | Milestone: | Release 3.2 |
Component: | Reflectometry | Keywords: | |
Cc: | Blocked By: | #9475 | |
Blocking: | #9371, #9470, #9673 | Tester: | Roman Tolchenov |
Description
While working on #9371 i enountered the problem where i couldn't access CreateTransmissionWorkspaceAuto from the unit tests. This is because it's a python algorithm.
Convert this algorithm to c++
Change History
comment:3 Changed 6 years ago by Keith Brown
- Status changed from assigned to inprogress
Refs #9500 CreateTransmissionWorkspaceAuto ported to C++
A new version of CreateTransmissionWorkspaceAuto has been created in c++
Python Unit test passes. Unable to port the unit test at this time as Stitch1D needs the same done to it in #9475
Changeset: 8332de7a573ede686f8a0acf02ba183fc5e76554
comment:5 Changed 6 years ago by Keith Brown
Refs #9500 Unit test converted
The unit test has been converted from C++ to pyhton
The Algorithm has had its Docs methods updated to the new single method style
Changeset: 5096b59ce0ef5704e0755b89d0f3cab871a1d33c
comment:6 Changed 6 years ago by Keith Brown
- Status changed from inprogress to verify
- Resolution set to fixed
To Tester
Inspect the code of the new C++ version and the python version to check for any discrepancies
Make sure both the C++ and python unit tests pass.
comment:7 Changed 6 years ago by Keith Brown
- Status changed from verify to reopened
- Resolution fixed deleted
comment:8 Changed 6 years ago by Keith Brown
- Status changed from reopened to inprogress
Refs #9500 GCC complier fix
the gcc compiler didn't like a call to getproperty. Hopefully this should fix it
Changeset: 2bcd3637009f73e7615f5bc5e5003577c1c523c6
comment:9 Changed 6 years ago by Keith Brown
Refs #9500 fix broken unit test
Due to a version comparison my new version broke AlgorithmHistoryTest. updated test for new version, but a more permanant colution should be added in #9672
Changeset: bd89d22ef2380dff9ac6b80eb1f200a34fe86e91
comment:10 Changed 6 years ago by Keith Brown
- Status changed from inprogress to verify
- Resolution set to fixed
comment:11 Changed 6 years ago by Keith Brown
- Blocking 9470 added
comment:13 Changed 6 years ago by Keith Brown
- Status changed from verify to reopened
- Resolution fixed deleted
Discovered that there are improvements to make and probably some more unit tests to port over
comment:14 Changed 6 years ago by Keith Brown
- Status changed from reopened to inprogress
Refs #9500 Tests all ported, python replaced
The versioning has been changed so that it directly replaces the pyhton version with no version incrment
The pyhton algorithm and test have gone
The remainder of the unit tests have been ported over
Changeset: 13759830a2d8bb71705f38ed1151de32af91e360
comment:15 Changed 6 years ago by Keith Brown
Refs #9500 Edited Cmake files for removed python
The cmake files no longer contain entires for CreateTransmissionWorkspaceAutoTest
Changeset: 2e13e4ba8ad92a87fa500788c0a51ce5463809c6
comment:16 Changed 6 years ago by Keith Brown
Refs #9500 remove exception references
exceptions were references in the TS_ASSERT_THROWS macros, i was told this wasn't the right way and shouldn't be references. Removed the & characters.
Changeset: 6ace511d538079e0f6fc2c6839246098a3c14d0e
comment:17 Changed 6 years ago by Keith Brown
Refs #9500 revert version check
i had changed the vesion AlgorithmHistoryTest looked for, but since I've changed it back (in order to be a staright replacement) this needed changing back
Changeset: baf94eeecb65c90b9284020a7bbec03ce6d971ae
comment:18 Changed 6 years ago by Keith Brown
- Status changed from inprogress to verify
- Resolution set to fixed
comment:19 Changed 6 years ago by Keith Brown
To Tester
Inspect the code of the new C++ version and the python version (on github, as it no longer exists on this branch) to check for any discrepancies
Make sure the C++ unit tests pass.
comment:20 Changed 6 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:21 Changed 6 years ago by Roman Tolchenov
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9500_CreateTransmissionWorkspaceAuto_To_Cpp'
Full changeset: 9e502c7b6c49537a41f74b6730d0fbad8b4e6c28
comment:22 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10343
How can this be a blocker?
We really can't possibly do a release because you are having trouble writing a unit test?