Ticket #9457 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Temporary "SANS2DTUBES" Workaround for IDF Problem

Reported by: Peter Parker Owned by: Peter Parker
Priority: blocker Milestone: Release 3.2
Component: SANS Keywords:
Cc: anders.markvardsen@… Blocked By:
Blocking: Tester: Anders Markvardsen

Description

We have #9367 (currently a work in progress) to deal with the IDF problems within the SANS ISIS interface. This is not a trivial job, and so in the meantime, just so the scientists can use the interface, it has been suggested we add a "SANS2DTUBES" option to the instrument dropdown menu as well as the ISISCommandInterface as a way to specify the latest version of the SANS2D instrument.

While I am changing the drop down, I will also remove the SANS2D_EVENT option.

Change History

comment:1 Changed 6 years ago by Peter Parker

  • Status changed from new to assigned
  • Owner set to Peter Parker

comment:2 Changed 6 years ago by Peter Parker

  • Component changed from Framework to SANS

comment:3 Changed 6 years ago by Peter Parker

  • Status changed from assigned to inprogress

Refs #9457 - Add SANS2DTUBES() to the ISISCommandInterface.

Changeset: c8049a8d46e1735772c2ee678973ab011aaba969

comment:4 Changed 6 years ago by Peter Parker

Refs #9457 - Add temp SANS2DTUBES option to GUI.

Replaced InstrumentSelector widget with plain QComboBox, as it was the easiest way to get SANS2DTUBES in the dropdown.

Some nasty hacks to accomodate the new option.

Everything in this commit should be reversed upon completion of #9367.

Changeset: 60abae42d2659c79c8de871ac989ac06bb1df6f1

comment:5 Changed 6 years ago by Peter Parker

  • Status changed from inprogress to verify
  • Resolution set to fixed

@Anders - to test:

  • Make sure flipping between the new SANS2DTUBES instrument and the other instruments works ok.
  • Do a reduction with some old SANS2D data (22048 + the "MaskSANS2DReductionGUI.txt" User File in System Tests should be fine). Make sure Display Mask works ok.
  • Do the same with some new SANS2D data. (23719, 23722, 23721, 23720, 23721, 23721 + "
    isis\inst$\NDXSANS2D\user\Masks\MASKSANS2D_141E_4m_SER_M3_8mm_FrontDet.txt" User File should be fine).
  • Make sure the system tests pass.

comment:6 Changed 6 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:7 Changed 6 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9457_temp_workaround_for_sans2dtubes_idf'

Full changeset: ​ce815a3b31df6d03ab6f5db9485a9e208afaac42

comment:8 Changed 6 years ago by Anders Markvardsen

Both examples tested with reduction and display mask view

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10300

Note: See TracTickets for help on using tickets.