Ticket #9556 (closed: fixed)
Add MUON DKT function
| Reported by: | Anders Markvardsen | Owned by: | Raquel Alvarez Banos |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Muon | Keywords: | |
| Cc: | mark.telling@…, stephen.cottrell@… | Blocked By: | |
| Blocking: | #11086 | Tester: | NickDraper |
Description
Add Muon_DynamicKuboToyabe function attached.
Mark Telling notes that: Can you please have a look and see if there is a problem with this function’s implementation – I believe it needs numerical integration methods
More information about this fuunction can be obtained from: mark telling, steve cottrell or aidy hillier
Attachments
Change History
comment:2 Changed 6 years ago by Anders Markvardsen
- Owner changed from Anders Markvardsen to Karl Palmen
comment:3 Changed 6 years ago by Anders Markvardsen
- Milestone changed from Backlog to Release 3.3
Will explain more next week
comment:5 Changed 6 years ago by Karl Palmen
I'll remove the 'Muon_' prefix and put the function in the muon category.
comment:6 Changed 6 years ago by Karl Palmen
First compilable draft re #9556
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 6ad852ff16d4054c8af5139e109834ce8306a3be
comment:7 Changed 6 years ago by Karl Palmen
Improve coding style re #9556
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 26acca47a123ea7edbf236e524367e8533602f77
comment:8 Changed 6 years ago by Karl Palmen
Further improvement in coding style re #9556
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: f0badd00fd93f69f4644681bc3cb62ba988912c6
comment:9 Changed 6 years ago by Karl Palmen
Coding improvements (3) re #9556
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 053f8b27d470b5a2bf1187b8da1b458babbd1a1c
comment:10 Changed 6 years ago by Karl Palmen
Change from IpeakFunction to ParamFunction re #9556
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: f15dbb283880a765839b566e4bbcf9d96f826dc2
comment:11 Changed 6 years ago by Karl Palmen
Change abs() to fabs() for getParameter re #9556
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 99d27b5642103389c91d74f0f4270e5ce337f681
comment:12 Changed 6 years ago by Nick Draper
Moved to the backlog at the code freeze of R3.3
comment:15 Changed 6 years ago by Anders Markvardsen
- Owner changed from Karl Palmen to Raquel Alvarez Banos
comment:16 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 DKT base implementation
Changeset: e7765fb7ffec4b6cd5e59a122e97812b6d05d8b9
comment:17 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 DKT updating parameter description
Changeset: fb9f1dce6329b9a624232841821980e6e350c7b7
comment:18 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 DKT documentation
Changeset: a5fab0cdf14aa55c3e00116098a9eb6ab7ae997a
comment:19 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 DKT updating setActiveParameter
Changeset: 5868103f80f76603b289d0de43d54bc64db68e81
comment:20 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 DKT unit test
Changeset: 5079fc94404a4323c0ff72bdc1849475707e862e
comment:21 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 Unit test testing function not fitting
Changeset: b977abd27292f4937e4ec55d0a124740158e80c1
comment:22 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 Fitting function improvements
Changeset: 06a5cb2fc14eb76dc3f9fdf0100eab2ca4f9d35c
comment:23 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 Removing unnecessary includes
Changeset: 55d48c53690e450b2484ae53d38ee8285a1a3a39
comment:24 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 removing math
Changeset: fb46f0e48eaee8628548678550c1f08a98b4538d
comment:25 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 fixing cpp checks
Changeset: 257ba6d75666e1106da7968b90949c9930bf70be
comment:26 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 remove unit test temporarily
Changeset: 2383727fa2b9035e4138a5b76abba5f136bc762d
comment:27 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 Enabling some unit tests
Changeset: f4d713c85eb1b344541189658a9416fb5a8807ab
comment:28 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 Some bugs fixed and unit test updated
Changeset: 1fa60d864765d9efdc6f090bfb02a78bc24869bd
comment:29 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 Fixing title overline in rst
Changeset: 96e3a4c2482ff2d39a10084b4a61d716ce7aeaad
comment:30 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 Splitting gz into ZFKT and HKT
Changeset: c7e744ac4fda568d33fb179871e83da5c0b41a80
comment:31 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 Updating function according to fortran code provided
Changeset: 1b5a920cb6fd985d56fe39bc57325314c0d8a154
comment:32 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 Updating some values and temporarily disabling some tests
Changeset: 6751422ddc59ef0e54afb5c1118dbb20edcc6921
comment:33 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 Being more strict with test results
Changeset: 59d368aeec062c028be0f0627f272c9de114c395
comment:34 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 Updating documentation
Changeset: e69074ae838df54df334628a1aba046e5adaec4a
comment:36 Changed 6 years ago by Raquel Alvarez Banos
The DKT function for zero external magnetic field is implemented here. Many details are likely to change (e.g. bin width for numerical integration, analytical approximation for very high hopping rates, ...) after discussion and feedback from muon scientists. These will be addressed in new tickets. In addition, I have created ticket #11086 to allow the fit to non-zero field data. I need additional information from Francis (I think he will be back next week) before starting working on it.
comment:37 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 updating notation, array indexing, bin width
Changeset: a04fcde29ddec64d204dd758684371b75c2486c9
comment:38 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 code refactoring
Changeset: cdaed80f734b07c421c3d520dbd72f0e3eb95831
comment:39 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 Removing unused macros
Changeset: b9d7582de4673dbd16636e96efbf124b272d4cc0
comment:40 Changed 6 years ago by Raquel
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #236.
comment:41 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 Commenting unused HKT function
Changeset: e96d4de07fcc6e4e885b6fee4841b163895a23b4
comment:42 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 Fixing size_t to double conversion
Changeset: 5ae7c880ea3d7da5b8cf3232fe74a7980414cf4f
comment:43 Changed 6 years ago by Raquel
Thanks for your comments, Nick. I will update the code according to your suggestions.
comment:44 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 Code cleaning
Changeset: 5608f05abe00ec22fcaafe221fdf9ca72af76de2
comment:45 Changed 6 years ago by Raquel Alvarez Banos
Re #9556 Removing more dead code
Changeset: 9be647abe2cf8232062b415ec50daecb7b944b80
comment:46 Changed 6 years ago by NickDraper
- Status changed from verify to closed
- Tester set to NickDraper
Merge pull request #236 from mantidproject/feature/9556_MuonDKT_function
Add DynamicKuboToyabe fitting function
Full changeset: a2f3876b2fe4119fd210e04fc3a604993a1dc3a0
comment:47 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10399
