Ticket #9641 (closed: fixed)
Clear PropertyMangerDataService When FrameworkManager is Cleared
Reported by: | Peter Parker | Owned by: | Peter Parker |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.2 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Martyn Gigg |
Description
On Windows we were having a problem where Mantid was taking a very long time to exit at the end of building the docs-test project.
Martyn narrowed this down to the PropertyManagerDataService not being cleared.
He recommended the following changes, which solved the problem.
Change History
comment:2 Changed 6 years ago by Peter Parker
Refs #9641 - Missing include.
Changeset: 3ffba94528dd23de1acabf9cf8f07d1cfd602e2c
comment:3 Changed 6 years ago by Peter Parker
Refs #9641 - Added similar test.
Changeset: 78cf0a123d3b00a564c56f1d93e78b18a7a0fd1b
comment:5 Changed 6 years ago by Peter Parker
- Status changed from assigned to verify
- Resolution set to fixed
To test:
On windows, building the docs-test target would run the tests, but then stay at
MantidUI-[Notice] MantidPlot is shutting down...
for a long time. Once you've merged and then ran docs-test, you should get
========== Build: 4 succeeded, 0 failed, 29 up-to-date, 0 skipped ==========
very soon after.
comment:6 Changed 6 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:8 Changed 6 years ago by Martyn Gigg
Could I also be slightly pedantic and ask that clearProperties be renamed clearPropertyManagers, just so it's a little more specific about what its clearing.
comment:9 Changed 6 years ago by Peter Parker
Refs #9641 - Change function name.
Changeset: 8e836e9ee116f70b7561a51a8f430420ee4118f3
comment:10 Changed 6 years ago by Peter Parker
Now published and check-built, with the changed name.
comment:11 Changed 6 years ago by Martyn Gigg
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/9641_clear_prop_man_data_service'
Full changeset: a514bc6992ca4cee553e42e7a667780b43abe4f3
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10484
Refs #9641 - Clear away PropertyManagers.
Changeset: 4e3783375c08375338d728054502cd692a66c762