Ticket #9642 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Python exception after running PredictFractionalPeaks

Reported by: Nick Draper Owned by: Martyn Gigg
Priority: major Milestone: Release 3.3
Component: Python Keywords:
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description (last modified by Karl Palmen) (diff)

Fix the bug, and reinstate the alg usage test (currently a code block).

This script runs the algs but errors after:

    ws=LoadIsawPeaks("TOPAZ_3007.peaks")
    LoadIsawUB(ws,"ls5637.mat")
    IndexPeaks(ws)

    PredictFractionalPeaks(ws,FracPeaks='wsPeaksOut',HOffset=[-0.5,0,0.5],KOffset=0,LOffset=[-0.5,0.5])

This script fails to run:

    ws=LoadIsawPeaks("TOPAZ_3007.peaks")
    LoadIsawUB(ws,"ls5637.mat")
    IndexPeaks(ws)

    wsPeaksOut = PredictFractionalPeaks(ws,HOffset=[-0.5,0,0.5],KOffset=0,LOffset=[-0.5,0.5])

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Martyn Gigg

  • Status changed from assigned to inprogress

Add an IPeaksWorkspaceProperty to Python

and put back the usage example for PredictFractionalPeaks that was failing. It failed because Python didn't understand the type of output it was trying to give back. Refs #9642

Changeset: ede3830b1da0123a21b9d8a6bf2c9ff91e3164d6

comment:3 Changed 6 years ago by Martyn Gigg

Add required boost:: qualifier for dynamic cast

Refs #9642

Changeset: dc1fe5215b6e9f0715411dac90ea245b00949fff

comment:4 Changed 6 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

Branch: bugfix/9642_py_except_predict_fractional

Tester: Check that the documentation has been updated to include the usage test as a doctest and verify that running the snippet of code now produces a new peaks workspace

comment:5 Changed 6 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:6 Changed 6 years ago by Karl Palmen

  • Description modified (diff)

comment:7 Changed 6 years ago by Karl Palmen

The code snippets run without any error messages, but PredictFractionalPeaks does not produce an output workspace with data.

The usage example runs in the build without error. It also runs in Mantidplot as shown in usage example and produces an output workspace with data.

comment:8 Changed 6 years ago by Karl Palmen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9642_py_except_predict_fractional'

Full changeset: 857bf7f1ca73ee9bb4f47391ee5ebaf9788480f4

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10485

Note: See TracTickets for help on using tickets.