Ticket #9725 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Should MuonLoad inherit from DataProcessor?

Reported by: Nick Draper Owned by: Anders Markvardsen
Priority: critical Milestone: Release 3.2
Component: Muon Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Parker

Description

With Nested History coming in this release is has become apparent hat MuoonLoad does not inherit from DataProcessor, and so will not benefit.

A cursory examination suggests it should.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Anders Markvardsen

  • Status changed from assigned to inprogress

Make MuonLoad inherit form dataflowalg. re #9725

Changeset: 649574abbaccbb8ea8a04ebc86185e5a7e6de819

comment:3 Changed 6 years ago by Anders Markvardsen

  • Status changed from inprogress to verify
  • Resolution set to fixed

To tester:

MuonLoad is used when loading data in MuonAnalysis

  1. In MantidPlot open interface to check that data can be loaded. Use Browse button and load musr data autotestdata or if at isis press 'current run' button
  1. check systemtest pass

comment:4 Changed 6 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:5 Changed 6 years ago by Peter Parker

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9725_muonload_dataprocessor'

Full changeset: ​7a09835b81962c483bba5cc788a68150c9585e43

comment:6 Changed 6 years ago by Peter Parker

Muon files still load okay in the interface, and all tests are passing.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10567

Note: See TracTickets for help on using tickets.