Ticket #9726 (closed: fixed)
Check Code Documentation and add Usage Examples
Reported by: | Karl Palmen | Owned by: | Karl Palmen |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.4 |
Component: | Documentation | Keywords: | |
Cc: | anders.markvardsen@…, nick.draper@… | Blocked By: | #10052 |
Blocking: | Tester: | Stuart Campbell |
Description
Please check the documentation for these algorithms (check images, formatting etc) and add testable algorithm usage examples. We have tried to allocate algorithms as fairly and sensibly as possible, but there will be some that you do not consider "yours".
There is help on how to document the algorithms in the following links: http://www.mantidproject.org/Algorithm_Documentation http://www.mantidproject.org/Algorithm_Usage_Examples And there are examples implemented for Fit, Load, LoadISISNexus and Rebin.
To create workspaces to use in your usages you should try to create the workspace using CreateSampleWorkspace or CreateWorkspace, and only use a file if you really have no other option and the size is small.
In Visual studio you have two targets to create the documentation and run the doc tests (docs-html and docs-test in a documentation subfolder). You will need to update your Third Party Library.
If you are using Linux/Mac look here: https://github.com/mantidproject/mantid/blob/master/Code/Mantid/docs/README.md
Algorithms:
- CopyLogs.cpp
- CreateTransmissionWorkspace.cpp
- FilterEvents.cpp
- FindPeaks.cpp
- GeneralisedSecondDifference.cpp
- GetTimeSeriesLogInformation.cpp
- MaskBins.cpp
- MaskBinsFromTable.cpp
- NormaliseByCurrent.cpp
- NormaliseToMonitor.cpp
- PerformIndexOperations.cpp
- ReadGroupsFromFile.cpp
- ReflectometryReductionOne.cpp
Crystal:
- ClearUB.cpp
- GoniometerAnglesFromPhiRotation.cpp
- IndexPeaks.cpp
- ShowPeakHKLOffsets.cpp
MD Algorithms:
- ThresholdMD.cpp
SINQ:
- MDHistoToWorkspace2D.cpp
WorkflowAlogirthms:
- StepScan.cpp
These are the algorithms outstanding from #9567
Change History
comment:4 Changed 6 years ago by Karl Palmen
Algorithms of category 'Algorithm' delegated to ticket #10052.
comment:5 Changed 6 years ago by Karl Palmen
- Status changed from assigned to inprogress
Usage Example for ThresholdMD re #9726
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 99dfaba202c9904f261250eb7e1d007f666a0e41
comment:6 Changed 6 years ago by Karl Palmen
Add usage example to MDHistoToWorkspace2D-v1.rst re #9726
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 7af3197b7c3b05af0067f54141c81c4e37f2f891
comment:7 Changed 6 years ago by Karl Palmen
Add start of flowchart for StepScan re #9726
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 82680b86b46cf118f78b0357692084f3075df327
comment:8 Changed 6 years ago by Karl Palmen
Add flowchart to StepScan-v1.rst re #9726
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 98d9ae93024d5f79bf45565b8f5738acc60a8694
comment:9 Changed 6 years ago by Karl Palmen
Add usage example to IndexPeaks re #9726
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 895192741887f5b3985706c1b6aefef268f4fb38
comment:10 Changed 6 years ago by Karl Palmen
- Blocked By 10077 added
comment:11 Changed 6 years ago by Karl Palmen
Enable ShowPeakHKLOffset to work in python re #9726
This required use of ITable instead of Table in algorithm and unit test for the output.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: bf67c21f53034e3423928fedb68f67be6e5729b0
comment:12 Changed 6 years ago by Karl Palmen
Changset accidentally committed to ticket #9762
comment:13 Changed 6 years ago by Karl Palmen
Add usage example to GoniometerAnglesFromPhiRotation re #9726
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: aab32ad4154ce8ad335a1133b46163cf01f1902a
comment:14 Changed 6 years ago by Karl Palmen
Add usage date note to GoniometerAnglesFromPhiRotation re #9726
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: b9a3e4be41ecc877d58c1004ec5a4026e2a96e94
comment:15 Changed 6 years ago by Karl Palmen
All four crystal algorithms have now had usage examples added.
comment:16 Changed 6 years ago by Karl Palmen
- Blocked By 10077 removed
comment:17 Changed 6 years ago by Nick Draper
- Milestone changed from Release 3.3 to Release 3.4
Moved to R3.4
comment:18 Changed 6 years ago by Karl Palmen
This ticket is awaiting branch to be updated and rendered fit for git checkbuild and eventual merger with source.
comment:19 Changed 5 years ago by Karl Palmen
This ticket has documentation added for 7 algorithms
ClearUB.cpp GoniometerAnglesFromPhiRotation.cpp IndexPeaks.cpp ShowPeakHKLOffsets.cpp ThresholdMD.cpp MDHistoToWorkspace2D.cpp StepScan.cpp
Either merging an up to date master into branch needs doing or copying changes to a new branch.
comment:20 Changed 5 years ago by Karl Palmen
I've decided to create new branch and copy the changes into it, merging with later changes if necessary.
comment:21 Changed 5 years ago by Karl Palmen
Add data file re #9726
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 17bef3de856d2d0940a4d5cd60991676b03f9b25
comment:22 Changed 5 years ago by Karl Palmen
Again accidentally committed change set cabebd8cf980611ccfad86338d1be4f3da559f05 to #9762.
comment:23 Changed 5 years ago by Karl Palmen
Deal with ShowPeakHKLOffests re #9726
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 396588090b1da4073d5278281bafd3d6b04dc2e3
comment:24 Changed 5 years ago by Karl Palmen
Add Stepscan flowchart re #9726
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: b9f2f7a4af48b5634825fd27cc7c593ba756258f
comment:25 Changed 5 years ago by Karl Palmen
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #666.
comment:26 Changed 5 years ago by Martyn Gigg
@KarlPalmen It looks like there is a crash in the unit tests for ShowPeakHKLOffsets
comment:27 Changed 5 years ago by Karl Palmen
Make ShowPeakOffsetTest use ITable re #9726
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 0396c19e5f0c81bd2bde9e3620149f444b37f90b
comment:28 Changed 5 years ago by Stuart Campbell
- Status changed from verify to verifying
- Tester set to Stuart Campbell
comment:29 Changed 5 years ago by Karl Palmen
I'm putting the usage data note in now.
comment:30 Changed 5 years ago by Karl Palmen
Add usage data not to IndexPeaks re #9726
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 388508cd58344a0a31befdd3ceb8ba43fd5b3972
comment:31 Changed 5 years ago by Stuart Campbell
- Status changed from verifying to closed
Merge pull request #666 from mantidproject/9726_documentation
Documentation for 7 algorithms including usage examples
Full changeset: bf7f69a3c14c3ac53a7240fd26862576bab3d06e
comment:32 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10568