Ticket #9826 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Refl_gui Fixes (Beta test feedback)

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: critical Milestone: Release 3.2
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Parker

Description

Various fixes needed to the Reflectometry GUI as part of the 3.2 beta testing. Ideally I would do these as separate tickets, but they should all be relatively small changes and are needed quickly.

  • ReflGUI should be able to be given pre-canned transmission workspaces (already converted into wavelength via CreateTransmissionWorkspace)
  • Stitching should happen as part of processing, now when 'Plot' is clicked.
  • Review whether loading is being used unnecessarily in the ReflGUI.

Change History

comment:1 Changed 6 years ago by Owen Arnold

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Owen Arnold

  • Status changed from assigned to inprogress

refs #9826. Stitch as part of process.

If stitch is checked, then the stitched output workspace will be generated as part of the processing. If it is done after, then it is completed as part of the plot process

Changeset: 729738a14aac545b9ff2811a2e8793f864d5c161

comment:3 Changed 6 years ago by Owen Arnold

Retested the new transmission workspace functionality. If there is a transmission workspace in the ADS, prior to processing (of the expected name) then NO TRANSMISSION workspaces will be created. This is the correct and requested functionality. I suspect that Max was beta testing an older version of the GUI that didn't have these features.

comment:4 Changed 6 years ago by Owen Arnold

refs #9826. Sort upon transfer.

This is max's prefered method of transfer

Changeset: 4704729951d0ced1c61be6218de383550819a3f4

comment:5 Changed 6 years ago by Owen Arnold

refs #9826. Refl workspace filter on save.

Changeset: 4f04ba520e4d1c74e2d57660280a0815c5f8a8c1

comment:6 Changed 6 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 6 years ago by Owen Arnold

Tester. Ask me for help testing these changes.

comment:8 Changed 6 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:9 Changed 6 years ago by Peter Parker

  • Status changed from verifying to reopened
  • Resolution fixed deleted

comment:10 Changed 6 years ago by Owen Arnold

  • Status changed from reopened to inprogress

refs #9826. Fix no theta issue.

Changeset: 40367bb3e0499a6c0dde7aaa468cf02f744d3773

comment:11 Changed 6 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:12 Changed 6 years ago by Peter Parker

  • Status changed from verify to closed

Merge remote-tracking branch 'origin/feature/9826_refl_beta_fixes'

Full changeset: ​e3c5f11db307f3e4f9b2a358d3d5ee6a65dbe323

comment:13 Changed 6 years ago by Peter Parker

Opened #9841 as a slight usability issue, but looks fine to me apart from that.

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10668

Note: See TracTickets for help on using tickets.