Ticket #9830 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

C2E: Bug in run diagnostics

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: minor Milestone: Release 3.2
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

There's a bug in diagnostics where you get an error if you choose to use a calibration file and the verbose option. Seems like the calib file isn't loaded before being used. 

NameError: global name 'calib' is not defined
  at line 11 in '<Interface>'
  caused by line 224 in '/home/chs18285/git/mantid/Code/Mantid/scripts/Inelastic/IndirectEnergyConversion.py'
  caused by line 181 in '/home/chs18285/git/mantid/Code/Mantid/scripts/Inelastic/IndirectEnergyConversion.py'

Change History

comment:1 Changed 6 years ago by Samuel Jackson

Refs #9830 Move logging statement to more sensible location.

Changeset: 3cdb28e7aa8724bf0c01a75fd9ec0fb9476f0f90

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Samuel Jackson

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:4 Changed 6 years ago by Samuel Jackson

To Tester

  • Confirm you can reproduce the error: Do a reduction from the indirect convert to energy interface, create a calibration file. Use them both as the input to the diagnostics tab. Check the verbose option and click run.
  • Check the changes fix it: do the same as above, you should not longer get the error.

Instructions for running indirect convert to energy and associated interfaces here:

http://www.mantidproject.org/Indirect:ConvertToEnergy

comment:5 Changed 6 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:6 Changed 6 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9830_diagnostics_error'

Full changeset: ​8c4bff6605cf9fa032c1c02224332244377bb1c6

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10672

Note: See TracTickets for help on using tickets.