Ticket #9831 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

C2E: Rebin in energy bug

Reported by: Samuel Jackson Owned by: Dan Nixon
Priority: minor Milestone: Release 3.3
Component: Indirect Inelastic Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

Rebinning a workspace in energy and using values that fall outside of the valid energy range throws this error which isn't terribly helpful for users: 

Error in execution of algorithm SofQW:
Workspace2D::getSpectrum, histogram number 14 out of range 14
RuntimeError: Workspace2D::getSpectrum, histogram number 14 out of range 14
  at line 12 in '<Interface>'
  caused by line 569 in '/home/chs18285/git/mantid/build/bin/mantid/simpleapi.py'

Find out where this is and throw a more user friendly error message.

Change History

comment:1 Changed 6 years ago by Samuel Jackson

  • Keywords Maintenance added

comment:2 Changed 6 years ago by Nick Draper

  • Owner changed from Samuel Jackson to Dan Nixon

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:4 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Added test for cause of error and more helpful error message

Refs #9831

Changeset: 3445a285d742c476ae7dd74235e3a73b500dece3

comment:5 Changed 6 years ago by Dan Nixon

  • Milestone changed from Backlog to Release 3.3

comment:6 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test:

  • Perform a basic indirect energy reduction via Indirect > Data Reduction > Energy Transfer (e.g. using IRS38633.raw in AutoTestData)
  • Select the workspace in S(Q, w) and click Plot Input
  • Enter reasonable values for Q rebin and values for energy rebin that are out of the actual energy range by at least 1
  • Click Run, notice more helpful error message in Results Log

comment:7 Changed 6 years ago by Dan Nixon

Added test for cause of error and more helpful error message

Refs #9831

Changeset: 5223ea432d1bb3dbca7bae86e73301e1847bff82

comment:8 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

The final comment was actually the merge to master but it came with a rebase that managed to remove the merge message. The effect is the same though.

comment:9 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10673

Note: See TracTickets for help on using tickets.