Ticket #9897 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Slow Unit Tests for Owen Arnold

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 3.3
Component: Framework Keywords: Maintenance
Cc: Blocked By: #9906, #9931, #9954, #10029, #10033, #10054
Blocking: #9905 Tester: Nick Draper

Description (last modified by Owen Arnold) (diff)

We have a number of slow running unit tests which we need to fix as part of the 3.3 maintenance window. We are targeting test suits than execute in > 2 seconds on our clean rhel6 build servers. For IO tests (Loading & Saving) we have applied a more generous threshold of > 5 seconds.

See the full list to see which tests have been assigned to you: http://www.mantidproject.org/images/2/2f/Slow_tests.xlsx_-_Sheet1.pdf

Criteria

  1. Test suits (each test class instance) should execute in < 1 second as a rough target
  2. As a corollary to the above, If the test suite contains lots of test methods aim for < 0.1 second per test method
  3. If for some reason you get the speed up the test below the target using the strategies listed below, you need to justify why when you close the ticket.

Guidelines/instructions to help

  1. Keep tests readable and improve code readability where possible. Unit tests are documentation.
  2. Do not delete test methods without good reason. We do not want to reduce test coverage
  3. Changing the algorithm code to improve speed is OK, but exercise caution. Add additional test coverage if it's not already good enough.
  4. Take test methods that are slow and involve IO, or are processor intensive and make them into system tests. Integration tests are not Unit tests.
  5. Most of the speed improvements will probably come from better selection of input data. Caching input data is also a good option.
  6. Create sub tickets for algorithms or groups of algorithms to help testability if you wish, but mark this ticket as the 'blocked' by each one.

Change History

comment:1 Changed 6 years ago by Owen Arnold

  • Status changed from new to assigned
  • Owner changed from Peter Parker to Owen Arnold
  • Description modified (diff)
  • Summary changed from Slow Unit Tests for Peter Parker (cloned) to Slow Unit Tests for Owen Arnold

comment:2 Changed 6 years ago by Owen Arnold

  • Blocking 9905 added

comment:3 Changed 6 years ago by Owen Arnold

  • Blocked By 9906 added

comment:4 Changed 6 years ago by Owen Arnold

  • Blocked By 9954 added

comment:5 Changed 6 years ago by Owen Arnold

  • Blocked By 9931 added

comment:6 Changed 6 years ago by Owen Arnold

  • Blocked By 10029 added

comment:7 Changed 6 years ago by Owen Arnold

  • Blocked By 10033 added

comment:8 Changed 6 years ago by Owen Arnold

  • Blocked By 10054 added

comment:9 Changed 6 years ago by Owen Arnold

  • Status changed from assigned to verify
  • Resolution set to fixed

Umbrella ticket. See individual fixes.

comment:10 Changed 6 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

Individual fixes complete, umbrella ticket closed

Nothing to merge

comment:11 Changed 6 years ago by Nick Draper

  • Status changed from verifying to closed

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10739

Note: See TracTickets for help on using tickets.