Ticket #9906 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

ReflectometryReductionOneAutoTest UnitTest too slow

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: #9897, #9954 Tester:

Description

ReflectometryReductionOneAutoTest UnitTest takes 15 seconds to run.

See #9904 for test instructions and timings.

Change History

comment:1 Changed 6 years ago by Owen Arnold

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Owen Arnold

  • Status changed from assigned to inprogress

refs #9906. Large speedup using pre-canned workspaces.

Reduced runtime from 25 seconds to 1.5 seconds using pre-canned workspaces. More refactoring needed.

Changeset: 8510ce62405123934b1acd641d93d8e856e8ad91

comment:3 Changed 6 years ago by Owen Arnold

refs #9906. More refactoring. More reuse. 0.8 second processing.

Changeset: 019af1a1f7369bd52455495d46668347998666c5

comment:4 Changed 6 years ago by Owen Arnold

After pushing to develop, the time that it takes to process has been reduced to 7 seconds (roughly half of the original). Next step will be to pull certain tests out into SystemTests.

comment:5 Changed 6 years ago by Owen Arnold

refs #9906. Create and use virtual refl instrument.

Make a very simple reflectometry instrument in memory and attach a single monitor and a single detector spectrum to it. Avoids All IO related to both data and instrument, and can be used to create tiny reflectometry workspaces.

Makes a huge difference to test speed. Only applied to ReflectometryReductionOne at this stage.

Changeset: 0c0a8297529d61bd52d4a18f750c0b1b14d608bf

comment:6 Changed 6 years ago by Owen Arnold

refs #9906. Ported more tests over and made faster.

Changeset: 655e8967927ecc36a1ae2c5b50c271531347b63a

comment:7 Changed 6 years ago by Owen Arnold

refs #9906. Fix compiler warnings.

Changeset: 63fca330df1a955d20b6b54c37cf05f1cff16363

comment:8 Changed 6 years ago by Samuel Jackson

  • Blocking 9904 removed

comment:9 Changed 6 years ago by Owen Arnold

refs #9906. unit test to system test.

Convert unit tests into system tests, but also update the stresstesting base class to derive from unittest TestCase to remove the need for customised assert methods.

Changeset: fa75635133cb9a6859dea15e8d24cb908c368e65

comment:10 Changed 6 years ago by Owen Arnold

refs #9906. Remove unit tests that are now sys tests.

Changeset: 42ac810cab5fbe55f6c9548801c6f82b42c98fa5

comment:11 Changed 6 years ago by Owen Arnold

Now have both unit tests for workflow algorithms ReflectometryReductionOne and ReflectometryReductionOneAuto executing in < 1 second.

comment:12 Changed 6 years ago by Owen Arnold

  • Blocking 9897 added

comment:13 Changed 6 years ago by Owen Arnold

  • Blocking 9954 added

comment:14 Changed 6 years ago by Owen Arnold

refs #9906. Python 2.6 limitation.

assertGreater, assertLess not supported until 2.7. Also forgot to add module.

Changeset: 308369608e5b2baea61dd08ba0c105008f657dbc

comment:15 Changed 6 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

Tester: You need to merge BOTH systemtest repo and mantid repo branches into their respective master branches!

Unit tests ReflectometryReductionOneAutoTest and ReflectometryReductionOneTest should execute very quickly now. Both in < 1 second.

Compare the original timings here: http://www.mantidproject.org/images/2/2f/Slow_tests.xlsx_-_Sheet1.pdf with the current ones here: http://builds.mantidproject.org/view/Develop%20Builds/job/develop_clean/label=rhel6-build/lastCompletedBuild/testReport/AlgorithmsTest/

The new system test RROAutoFunctionalityTest should be up and running on all platforms.

Last edited 6 years ago by Owen Arnold (previous) (diff)

comment:16 Changed 6 years ago by Owen Arnold

refs #9906. Fix windows warning.

Changeset: 3c5073a9f1f27816201d442be64bad018ab6adee

comment:17 Changed 6 years ago by Nick Draper

  • Status changed from verify to closed

Merge remote-tracking branch 'origin/feature/9906_RRO_auto_unit_test'

Full changeset: 9941e2556587bce0e05cd0b6464d6f82668aed3e

comment:18 Changed 6 years ago by Nick Draper

Merge remote-tracking branch 'origin/feature/9906_RRO_auto_unit_test'

Full changeset: f3ca6658d72083afaf57829f96795fe8ec8a571f

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10748

Note: See TracTickets for help on using tickets.