Ticket #9984 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Cross-correlation algorithm for Corelli

Reported by: Ross Whitfield Owned by: Ross Whitfield
Priority: major Milestone: Release 3.3
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

This should calculate the elastic signal from the total ToF and the top-dead-centre time from the correlation chopper. The signal is applied in the form of a weight on each event. A new IDF for Corelli will also be needed, containing the correlation chopper sequence.

Change History

comment:1 Changed 6 years ago by Ross Whitfield

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Ross Whitfield

  • Status changed from assigned to inprogress

Refs #9984 Add correlation chopper info to the Corelli IDF.

Changeset: a6d4828e61309d61fc934e17bca42b0b5ea9bd52

comment:3 Changed 6 years ago by Ross Whitfield

Refs #9984 Add blank CorelliCrossCorrelation alg, using class_maker.

Changeset: befcbc7a20876410d00fcd37785694c87e5bb6bd

comment:4 Changed 6 years ago by Ross Whitfield

Refs #9984 Read in WS, instrument and chopper info.

Changeset: 41290ad32e3c845437925f0ef38827acd1161081

comment:5 Changed 6 years ago by Ross Whitfield

Refs #9984 Got cross-correlation doing something.

Changeset: 57b8daeaf64c1d3f3753e06d384acd7a9319699c

comment:6 Changed 6 years ago by Ross Whitfield

Refs #9984 Cleanup and small fixes.

Changeset: e45b053db7c03006d60fc474d25713c9a2dd376b

comment:7 Changed 6 years ago by Ross Whitfield

Refs #9984 Fixed weights (maybe).

Changeset: 017bc5e25717f508e55bc50b405643e04454f5dd

comment:8 Changed 6 years ago by Ross Whitfield

Refs #9984 Added parallel and progress.

Changeset: 55ae26f12adba961efbbd63e20537631f9acdedc

comment:9 Changed 6 years ago by Ross Whitfield

Refs #9984 Added weight errors.

Changeset: 52e0c064032daa1eb9ba4d813a7e6351d5651cdf

comment:10 Changed 6 years ago by Ross Whitfield

Refs #9984 Unit test added.

Changeset: 4e69cb76d0509924447b540d3b013219caa22dc6

comment:11 Changed 6 years ago by Ross Whitfield

Refs #9984 Change how chopper period is determined.

Changeset: 37ffce8018ce4f5dcbaa8a2e573e3b6179717622

comment:12 Changed 6 years ago by Ross Whitfield

Refs #9984 Add check for sorted workspace.

Changeset: a5717610ce942c54a69eae4ac9dd84aa02b271d9

comment:13 Changed 6 years ago by Ross Whitfield

Refs #9984 Check bounds of tdc index.

Changeset: b5e86385d7a7ccbdfcb341fd8fe58d9b758cdc6d

comment:14 Changed 6 years ago by Ross Whitfield

Refs #9984 Fix check bounds of tdc index.

Changeset: a943a181f72909375fa163ccb081c18f0056cc57

comment:15 Changed 6 years ago by Ross Whitfield

  • Priority changed from minor to major

comment:16 Changed 6 years ago by Ross Whitfield

Refs #9984 Moved workspace validators to validateInputs.

Changeset: 542281c7d5cb738da906e066345d006c6827a62b

comment:17 Changed 6 years ago by Ross Whitfield

Refs #9984 Moved more things to validateInputs and other cleanup.

Changeset: 5bf1450abc7c7bd208f3b2c7f75b1d5decfcc038

comment:18 Changed 6 years ago by Ross Whitfield

Refs #9984 Add some documentation and usage example.

Changeset: 35caf31d0e99a8f1233935dfb88fcf13ba07e5bc

comment:19 Changed 6 years ago by Ross Whitfield

Refs #9984 Add t0 formula and applied it in the cross-correlation.

Changeset: 27b258f7be77da9eb650c519945eb8e91a10436e

comment:20 Changed 6 years ago by Ross Whitfield

Refs #9984 Add usage test data. Updated unit test and usage exmaple.

Changeset: 8a00a5b050da22f7ccc004c63d154820537d6de8

comment:21 Changed 6 years ago by Ross Whitfield

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #49.

comment:22 Changed 6 years ago by Ross Whitfield

Refs #9984 Change stod to lexical_cast.

Changeset: 42227f6798c79c167ddaab909feae6b2d54ce8ff

comment:23 Changed 6 years ago by Ross Whitfield

Refs #9984 Change TimingOffset property from int64_t to int.

Changeset: dabaab76c42847de66adad43019317b449591e3b

comment:24 Changed 6 years ago by Ross Whitfield

Refs #9984 Fix tdc[tdc_i] out-of-bounds error.

Changeset: 55c78c2b1c5658a9cffadc5497fc7a437c3844fa

comment:25 Changed 6 years ago by Martyn Gigg

Sorry for the delay but I think your most recent fix is the correct thing to do.

comment:26 Changed 6 years ago by Ross Whitfield

The segfaults when using group workspaces and will need to be fixed before testing.

comment:27 Changed 6 years ago by Ross Whitfield

Refs #9984 clang-format it.

Changeset: 1fffa1a174c827125c111bc19d5154bed4267068

comment:28 Changed 6 years ago by Peter Peterson

  • Tester set to Andrei Savici

comment:29 Changed 6 years ago by Andrei Savici

  • Status changed from verify to verifying

comment:30 Changed 6 years ago by Ross Whitfield

Refs #9984 Add protection from workspace groups in validateInputs.

Changeset: ffebd7931d3edf2424506a9d1606c1f1bfe719aa

comment:31 Changed 6 years ago by Ross Whitfield

  • Status changed from verifying to closed

Merge branch 'master' into feature/9984_corelli_cross_correlate

Conflicts:

Code/Mantid/instrument/CORELLI_Definition.xml Code/Mantid/instrument/CORELLI_Parameters.xml

Full changeset: ​2687830fc4293763be92ad2197750655e8ed27f1

comment:32 Changed 6 years ago by Ross Whitfield

Merge remote-tracking branch 'origin/master' into feature/9984_corelli_cross_correlate

Full changeset: ​85b9d24aa502b125bedcc3e2c4386f960c27df2e

comment:33 Changed 6 years ago by AndreiSavici

Merge pull request #49 from mantidproject/feature/9984_corelli_cross_correlate

Corelli cross-correlation algorithm

Full changeset: ​415fe581c23c4299c0d663fa1df2b9ede5b41bee

comment:34 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10826

Note: See TracTickets for help on using tickets.