Ticket #1513 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

MergeRuns for EventWorkspaces

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

... should add event lists together, rather than create a workspace 2D out of it.

Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Milestone changed from Iteration 24 to Iteration 25

comment:2 Changed 10 years ago by Janik Zikovsky

(In [5869]) Refs #1513: Laying the groundwork for later actual work.

comment:3 Changed 10 years ago by Janik Zikovsky

(In [6043]) Refs #1513: more work for MergeRuns for EventWorkspaces

comment:4 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

forgot to accept

comment:5 Changed 10 years ago by Janik Zikovsky

(In [6100]) Refs #1605 and #1595 in a way. Made spectrum numbers and workspace indices match (simple 1:1 map) for EventWorkspaces. Added tracking of detector ID in EVentList. Operators (+) do a union of detector IDs set. SpectraDetectorMap is generated from the EventList detector IDs. Renamed functions to clarify getEventList and getEventListAtWorkspaceIndex. New functions for finalizing the creation of EventWorkspaces. Fixed DiffractionFocussing and ConjoinWorkspaces to use the new functionality - code is made a lot clearer. This work supports Refs #1513 and #1581.

comment:6 Changed 10 years ago by Janik Zikovsky

(In [6105]) Refs #1513: MergeRuns works for EventWorkspaces, including when pixel IDs are mismatched or when grouped.

comment:7 Changed 10 years ago by Janik Zikovsky

(In [6106]) Refs #1513: More unit testing for MergeRuns.

comment:8 Changed 10 years ago by Janik Zikovsky

Note: how are frame times to be handled?

comment:9 Changed 10 years ago by Janik Zikovsky

(In [6127]) Refs #1513: Added test with real CNCS data. Much improved speed for mismatched workspace indices, but only for 1 detector per spectrum; this could still take forever if the indices are mismatched, there are lots of spectra, and not all have one detector. This should be a very unusual occurrence (can't think of a way to do this).

comment:10 Changed 10 years ago by Janik Zikovsky

(In [6143]) Refs #1617: Using the absolute pulse time in events instead of a frame index value that needs to be looked up. This also refs #1513, addressing issues of merging disparate runs.

comment:11 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [6144]) Fixes #1513. Looks like all possible permutations are tested for. Frame times are handled in a natural way.

comment:12 Changed 10 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Component set to Mantid
  • Tester set to Vickie Lynch

comment:13 Changed 10 years ago by Vickie Lynch

  • Status changed from verifying to closed

Merged event workspaces for SNAP prenexus files for 4111 and merged workspace is the same as the event nexus file for the same experiment.

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2360

Note: See TracTickets for help on using tickets.