Ticket #1595 (closed: wontfix)

Opened 10 years ago

Last modified 5 years ago

Create a SpectraAxis subclass that simplifies Workspace Index -> Spectrum Number mapping.

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: pf9@… Blocked By:
Blocking: Tester: Nick Draper

Description

The SpectraAxis is only useful to ISIS instruments where the spectrum numbers start at 1, whereas the workspace indices must start at 0.

This subclass would be used, e.g., by EventWorkspace. It would be the equivalent of having a simple 1:1 map.

Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

Also, the EventWorkspace class should be refactored to use a simple 1:1 workspace index -> spectrumNumber axis.

comment:2 Changed 10 years ago by Janik Zikovsky

(In [6100]) Refs #1605 and #1595 in a way. Made spectrum numbers and workspace indices match (simple 1:1 map) for EventWorkspaces. Added tracking of detector ID in EVentList. Operators (+) do a union of detector IDs set. SpectraDetectorMap is generated from the EventList detector IDs. Renamed functions to clarify getEventList and getEventListAtWorkspaceIndex. New functions for finalizing the creation of EventWorkspaces. Fixed DiffractionFocussing and ConjoinWorkspaces to use the new functionality - code is made a lot clearer. This work supports Refs #1513 and #1581.

comment:3 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to wontfix

Changed my mind on this one - See Rev [6100]. Code in EventWorkspace creates a simple 1:1 map which is simpler than subclassing SpectraAxis. Maybe later it could still be done.

comment:4 Changed 10 years ago by Nick Draper

  • Status changed from verify to verifying
  • Component set to Mantid
  • Tester set to Nick Draper

comment:5 Changed 10 years ago by Nick Draper

  • Status changed from verifying to closed

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2442

Note: See TracTickets for help on using tickets.