Ticket #1581 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Plus: implement for EventWorkspaces

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Whitty

Description


Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

This is needed by #1513...

comment:2 Changed 10 years ago by Janik Zikovsky

(In [6062]) Refs #1581: Plus operator for EventWorkspaces; might not work in mantidplot yet.

comment:3 Changed 10 years ago by Janik Zikovsky

(In [6063]) Refs #1581: Hope this will make the test pass under Windows/Mac; don't know why it only worked on Linux.

comment:4 Changed 10 years ago by Janik Zikovsky

(In [6065]) Refs #1581: To fix PlusTest

comment:5 Changed 10 years ago by Janik Zikovsky

(In [6088]) Refs #1581: Added a test and unit checking for Plus for event workspaces

comment:6 Changed 10 years ago by Janik Zikovsky

(In [6100]) Refs #1605 and #1595 in a way. Made spectrum numbers and workspace indices match (simple 1:1 map) for EventWorkspaces. Added tracking of detector ID in EVentList. Operators (+) do a union of detector IDs set. SpectraDetectorMap is generated from the EventList detector IDs. Renamed functions to clarify getEventList and getEventListAtWorkspaceIndex. New functions for finalizing the creation of EventWorkspaces. Fixed DiffractionFocussing and ConjoinWorkspaces to use the new functionality - code is made a lot clearer. This work supports Refs #1513 and #1581.

comment:7 Changed 10 years ago by Janik Zikovsky

(In [6101]) Refs #1581: Plus algorithm completed for Event Workspaces. Event Lists are added even if from different pixel IDs. Use MergeRuns (when it is done) do merge disparate EventWorkspaces.

comment:8 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Looks to work well and tests are thorough.

comment:9 Changed 10 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Component set to Mantid
  • Tester set to Michael Whitty

comment:10 Changed 10 years ago by Michael Whitty

  • Status changed from verifying to closed

seems to work in a comparable manner as the Plus algorithm for non-event workspaces.

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2428

Note: See TracTickets for help on using tickets.