Ticket #1784 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

BinaryOperation: extend to handle EventWorkspaces and EventLists. Implement on the Plus algorithm.

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Whitty

Description

Overload performBinaryOperation() with EventList as the argument where needed. Other algorithms (Multiply, Divide) then will just implement that overload.

See also #1781.

Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Janik Zikovsky

(In [7058]) Refs #1784: Reworked the BinaryOperation framework to handle EventWorkspaces in a more general fashion. Tested working with the Plus algorithm.

comment:3 Changed 10 years ago by Janik Zikovsky

(In [7081]) Refs #1784: Minus operator on EventList

comment:4 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Framework of binary operation is now sufficiently general-purpose to handle combining event workspaces in any combination...

comment:5 Changed 10 years ago by Martyn Gigg

(In [7108]) Fix a test on Windows. Re #1784

comment:6 Changed 10 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester set to Michael Whitty

comment:7 Changed 10 years ago by Michael Whitty

  • Status changed from verifying to closed

Plus works (ticket #1581), divide works as it does for non-event, multiply worked, minus worked. All good! Minus seemed to be a lot slower that all the others though.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2631

Note: See TracTickets for help on using tickets.