Investigate possible memory leak from unreleased use of poco XML document and node lists.

[Alex Buts]

It was noticed during the work on unrelated ticket #6447, that there is possible memory leak in the Box controller code transforming BC to/from xml. This has been found not to be the case, but similar have been found elsewhere in the code.

Possible memory leaks arising from non-release of Poco::XM::document and any node list extracted from it should be investigated and fixed if identified.

[Karl Palmen]

Investigation has shown that because the code of BoxController uses a Poco::AutoPtr. The release is not necessary, but it has been ound to be necessary, but is found to be necessary in other parts of the code such as InstrumentDefinitionParser, which uses bare Poco::Document pointers and these do require the release calls. So I extend this ticket to include such cases.

[Karl Palmen]

If find the following include 'Poco::XML'

API

ImplicitFunctionFactory, ImplicitFunctionParameter, ImplicitFunctionParameterParser, ImplicitFunctionParameterParserFactory, ImplicitFunctionParser, ImplicitFunctionParserFactory and some unit tests thereof

SingleValueParameterParser, VectorParameterParser, VectorParameterTest

BoxController, ExperimentInfo

Algorithms CreateDummyCalFile, ReadGroupsFromFile, DetectorEfficiencyCorTest

MantidQT/CustomInterfaces IO_MuonGrouping

DataHandling ConvertFullprofToXML, LoadCanSAS1D, LoadCanSAS1D2, LoadDetectorsGroupingFile, LoadMask, LoadSpice2D, FindDetectorsInShape, GenerateGroupingPowder, LoadInstrument, LoadParameterFile, LoadPreNexus, LoadPreNexusMonitors, SaveDetectorsGrouping, SNSDataArchive, ConvertFullprofToXMLTest

Geometry Component, ComponentParser, IMDDimensionFactory, InstrumentDefinitionParser, ShapeFactory, vtkGeometryCacheReader, CompositeImplicitFunction, MDGeometryXMLBuilder, MDGeometryXMLParser, MDHistoDimension, MDPlaneImplicitFunction and unit tests for some of them.

Kernel CalalogInfo, FacilityInfo, InstrumentInfo, RemoteJobManager, XMLInstantiator, ConfigService and some unit tests for them

LiveData SNSLiveEventDataListener, ADARAPacketTest,

MDAlgorithms InvalidParameterParser, Vector3DParameterParser, BinMDTest, InvalidParameterParserTest

MDEvents AffineMatrixParameterParser, CoordTransformAffineParser, CoordTransformDistanceParser and unit tests

MantidQT/SliceViewer SliceViewer

SINQ SINQHMListener

[Karl Palmen]

ImplicitFunctionParameterParserFactoryImpl::createImplicitFunctionParameterParserFromXML uses a NodeList* (ordinary pointer) without releasing it, as does ImplicitFunctionParserFactoryImpl::createImplicitFunctionParserFromXML

ImplicitFunctionFactoryImpl::createUnwrapped creates a Document* without releasing it.

[Karl Palmen]

Most for the code listed uses Document* or NodeList* without calling the release fumnction. I did find a few exceptions.

[Karl Palmen]

The code in Geometry, Kernel and LiveData is generally better behaved.

[Karl Palmen]

I've created tickets #8483 #8484 #8485 #8486 #8487 #8489 #8490 #8491 and #8492 to cover the unresolved cases in different areas of the code.

[Karl Palmen]

To test check the tickets covering the oytstanding issues. Do not run git macros.

[Gesner Passos]

I found that these files uses Poco xml as well:

Mantid/Vates/VatesAPI/src/vtkDataSetToWsLocation.cpp
Mantid/Vates/VatesAPI/src/vtkDataSetToWsName.cpp

Besides, the description of the tickets suggest to use release, but, prefer the AutoPtr, as it is the preferable way given by the documentation of Poco.

[Karl Palmen]

Tickets modified to request fixing by AutoPtr.

[Karl Palmen]

Added ticket #8511 for VATES.

[Gesner Passos]

Now, at least, we have tickets created for all the usages of xml poco library.

[Stuart Campbell]

This ticket has been transferred to github issue ​8898